Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[BRMO-259] fix P8 API test welke nu geboortedatum met een verzonnen timestamp aanlevert#1654

Merged
mprins merged 1 commit into
masterB3Partners/brmo:masterfrom
BRMO-259_fix_P8_testcasesB3Partners/brmo:BRMO-259_fix_P8_testcasesCopy head branch name to clipboard
Jan 16, 2023
Merged

[BRMO-259] fix P8 API test welke nu geboortedatum met een verzonnen timestamp aanlevert#1654
mprins merged 1 commit into
masterB3Partners/brmo:masterfrom
BRMO-259_fix_P8_testcasesB3Partners/brmo:BRMO-259_fix_P8_testcasesCopy head branch name to clipboard

Conversation

@mprins

@mprins mprins commented Jan 16, 2023

Copy link
Copy Markdown
Member

Voor ieder datum element in de json "verrijkt" de P8 API die met het tijdstip van opvragen; in dit geval geboortedatum.; dat is een bug die er al jaren in zit.

De geboortedatum werd tot voor kort niet teruggegeven uit de API.

@mprins mprins self-assigned this Jan 16, 2023
@mprins mprins added the rsgb label Jan 16, 2023
@mprins mprins added this to the 3.0.0 milestone Jan 16, 2023
@mprins mprins added the bug label Jan 16, 2023
@codecov

codecov Bot commented Jan 16, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1654 (fb26fbc) into master (e476224) will increase coverage by 1%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #1654    +/-   ##
=========================================
+ Coverage        37%     37%    +1%     
- Complexity      810     948   +138     
=========================================
  Files           414     414            
  Lines         21670   21670            
  Branches       2029    2029            
=========================================
+ Hits           7889    7964    +75     
+ Misses        13163   13083    -80     
- Partials        618     623     +5     
Impacted Files Coverage Δ
...er/src/main/java/nl/b3p/brmo/loader/RsgbProxy.java 73% <0%> (+1%) ⬆️
...o/service/stripes/AdvancedFunctionsActionBean.java 26% <0%> (+1%) ⬆️
...va/nl/b3p/brmo/bag2/loader/cli/BAG2LoaderMain.java 55% <0%> (+1%) ⬆️
...src/main/java/nl/b3p/brmo/loader/StagingProxy.java 66% <0%> (+2%) ⬆️
.../main/java/nl/b3p/brmo/bgt/loader/BGTDatabase.java 63% <0%> (+4%) ⬆️
...ain/java/nl/b3p/brmo/bag2/loader/BAG2Database.java 57% <0%> (+11%) ⬆️
...java/nl/b3p/brmo/bag2/schema/BAG2SchemaMapper.java 100% <0%> (+59%) ⬆️
...in/java/nl/b3p/brmo/sql/dialect/OracleDialect.java 72% <0%> (+72%) ⬆️

@mprins
mprins merged commit ca93c5d into master Jan 16, 2023
@mprins
mprins deleted the BRMO-259_fix_P8_testcases branch January 16, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.