Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Extract shared selector chains and DOM helpers #3

Copy link
Copy link

Description

@aviclaw01
Issue body actions

Problem

adapter.js (CLI tool) and server.js both define their own copies of:

  • SELECTOR_CHAINS object
  • findElement(), findAllElements(), waitForAny() helpers
  • waitForCompletion() (different implementations)

This means selector updates need to be made in two places, and the implementations can drift.

Proposed fix

Extract shared selectors and DOM helpers into a lib/domHelpers.js module and import from both server.js and adapter.js.

Reactions are currently unavailable

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    Morty Proxy This is a proxified and sanitized view of the page, visit original site.