Adding database table name prefix support#1064
Open
egaudrain wants to merge 1 commit into
Open
Adding database table name prefix support#1064egaudrain wants to merge 1 commit into
egaudrain wants to merge 1 commit into
Conversation
Prefix is important for managed hosts where creating a database for Attendize may not be possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Table prefixes are important for managed hosts where creating a database for Attendize may not be possible.
I added an option in the
.envfile and declared the prefix inconfig/database.php. However, becauseMyBaseModel.phpis using a raw query, the prefix is not taken into account. The proposed fixed is a bit ugly. It would probably be better to either not use a raw query, or at least to get the prefix from the Lavarel database instance... but I'm not familiar enough with this framework to pull this.Also note that I entered
attendize_as default prefix in.env.example, but use an empty string''inconfig/database.php. I think this is consistent, because keeping an empty entry in the example file would not be very self-explanatory, but this may not be consistent with what has been done for other options.