Core show channels action and minor improvements#274
Open
AlexAlexKud wants to merge 10 commits into
AsterNET:masterAsterNET/AsterNET:masterfrom
AlexAlexKud:CoreShowChannelsImprovementAlexAlexKud/AsterNET:CoreShowChannelsImprovementCopy head branch name to clipboard
Open
Core show channels action and minor improvements#274AlexAlexKud wants to merge 10 commits intoAsterNET:masterAsterNET/AsterNET:masterfrom AlexAlexKud:CoreShowChannelsImprovementAlexAlexKud/AsterNET:CoreShowChannelsImprovementCopy head branch name to clipboard
AlexAlexKud wants to merge 10 commits into
AsterNET:masterAsterNET/AsterNET:masterfrom
AlexAlexKud:CoreShowChannelsImprovementAlexAlexKud/AsterNET:CoreShowChannelsImprovementCopy head branch name to clipboard
Conversation
AbstractChannelEvent inherits ResponseEvent; CoreShowChannelsAction inherits ManagerActionEvent; Added events CoreShowChannelEvent and ;CoreShowChannelsCompleteEvent; Added support for TimeSpan and Guid properies;
usender
reviewed
May 18, 2023
Collaborator
|
I can see that you changed indention from four spaces ( Of course, now that I think about there, there is a an option to hide whitespaces in the diff. But is is annoying to read the code on GitHub when the indention doesn't match. |
Author
Fair remark! Fixed |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better support CoreShowChannelsAction:
MAIN:
AbstractChannelEvent now inherits ResponseEvent;
CoreShowChannelsAction now inherits ManagerActionEvent;
Added events CoreShowChannelEvent and ;CoreShowChannelsCompleteEvent;
BTW:
Added support for TimeSpan and Guid properies in Parsing and ToString methods;
Added AssemblyInfo attributes autogeneration ignore - this gives build an error in VS 2022
EXAMPLE:
Now you can use CoreShowChannelsAction and receives its responses: