Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix build errors#259

Open
dzuerrer wants to merge 3 commits into
AsterNET:masterAsterNET/AsterNET:masterfrom
dzuerrer:masterdzuerrer/AsterNET:masterCopy head branch name to clipboard
Open

fix build errors#259
dzuerrer wants to merge 3 commits into
AsterNET:masterAsterNET/AsterNET:masterfrom
dzuerrer:masterdzuerrer/AsterNET:masterCopy head branch name to clipboard

Conversation

@dzuerrer

Copy link
Copy Markdown

It seems the build is broken due to assembly level attributes being defined multiple times.

@Deantwo

Deantwo commented Sep 24, 2021

Copy link
Copy Markdown
Collaborator

Where else are they defined?

@dzuerrer

Copy link
Copy Markdown
Author

They are generated from this section in the AsterNet.csproj project file:

image

@stoyandimov

Copy link
Copy Markdown
Contributor

Targeting .NETStandard2.0 is very important to us.

@Deantwo

Deantwo commented Mar 7, 2022

Copy link
Copy Markdown
Collaborator

Targeting .NETStandard2.0 is very important to us.

It is untested here, and I don't know if we can just update the NuGet package with this change without causing issues. So it likely won't be changed any time soon, unless we suddenly get more people interested in this project and thereby more people to test this.

If you need it that badly, I suggest you make your own fork or download the source, then change it there and build it yourself.

@stoyandimov

Copy link
Copy Markdown
Contributor

Targeting .NETStandard2.0 is very important to us.

It is untested here, and I don't know if we can just update the NuGet package with this change without causing issues. So it likely won't be changed any time soon, unless we suddenly get more people interested in this project and thereby more people to test this.

If you need it that badly, I suggest you make your own fork or download the source, then change it there and build it yourself.

Thanks for the reply. We have our eyes on that for our next .NET Core project. I will do as you suggest and test it. Will contribute back if any fixes we do work well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.