Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Call Parking Action Improved by Adding Additional Parameter #229

Open
nirzaf wants to merge 4 commits into
AsterNET:masterAsterNET/AsterNET:masterfrom
nirzaf:masternirzaf/AsterNET:masterCopy head branch name to clipboard
Open

Call Parking Action Improved by Adding Additional Parameter #229
nirzaf wants to merge 4 commits into
AsterNET:masterAsterNET/AsterNET:masterfrom
nirzaf:masternirzaf/AsterNET:masterCopy head branch name to clipboard

Conversation

@nirzaf

@nirzaf nirzaf commented Feb 6, 2020

Copy link
Copy Markdown

Call Parking Action Improved by Adding Additional Parameter

Fixes #228

Announce Channel in AsterNET not Available in ParkAction, fix for this issue AsterNET#228
Missing Variables forAnnounceChannel & TimeoutChannel and Replaced Channel 2 by TimeoutChannel Variable
@Deantwo Deantwo linked an issue Feb 6, 2020 that may be closed by this pull request

@Deantwo Deantwo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small issue of backward compatibility and some summary comments.

Otherwise it looks fine.

@skrusty we aren't gonna stop supporting Asterisk versions <12, right?

public string TimeoutChannel { get; set; }

/// <summary>
/// Set the Announcement Channel to receive the AMI Announcement.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the full parameter description shown on the Asterisk Documentation:
https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+ManagerAction_Park

Channel name to use when constructing the dial string that will be dialed if the parked channel times out. If TimeoutChannel is in a two party bridge with Channel, then TimeoutChannel will receive an announcement and be treated as having parked Channel in the same manner as the Park Call DTMF feature.

@@ -50,7 +54,12 @@ public override string Action
/// <summary>
/// Set the Channel where the Call will end up after the timeout is reached.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add the full parameter description shown on the Asterisk Documentation:
https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+ManagerAction_Park

If specified, then this channel will receive an announcement when Channel is parked if AnnounceChannel is in a state where it can receive announcements (AnnounceChannel must be bridged). AnnounceChannel has no bearing on the actual state of the parked call.

Comment thread Asterisk.2013/Asterisk.NET/Manager/Action/ParkAction.cs
@Deantwo Deantwo added the bug A bug in the project that needs to be fixed. label Feb 6, 2020
@Deantwo Deantwo added this to the Version 2.0 milestone Feb 6, 2020
Park Action Update Preserving the Backward Compatibility,
@@ -52,6 +70,16 @@ public override string Action
/// </summary>
public string Channel2 { get; set; }

@Deantwo Deantwo Feb 7, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy way didn't work?

public string Channel2 { get { return TimeoutChannel; } set { TimeoutChanne = value; } }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A bug in the project that needs to be fixed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Announce Channel in AsterNET not Available in ParkAction

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.