Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fixes to determining Asterisk version#221

Merged
Deantwo merged 3 commits into
AsterNET-1.xAsterNET/AsterNET:AsterNET-1.xfrom
NewAsteriskVersionsAsterNET/AsterNET:NewAsteriskVersionsCopy head branch name to clipboard
Apr 23, 2021
Merged

Fixes to determining Asterisk version#221
Deantwo merged 3 commits into
AsterNET-1.xAsterNET/AsterNET:AsterNET-1.xfrom
NewAsteriskVersionsAsterNET/AsterNET:NewAsteriskVersionsCopy head branch name to clipboard

Conversation

@Deantwo

@Deantwo Deantwo commented Jan 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Added up to version Asterisk v17.
Added an attempt to detect future versions.

Fixes #202
Fixes #220
Fixes #250

@Deantwo
Extended AsteriskVersion Enum
acd9e88 
Added an "Unknown" option.
Added Asterisk version up to 17.
Added a "Newer" option.
@Deantwo Deantwo added the bug A bug in the project that needs to be fixed. label Jan 21, 2020
@Deantwo Deantwo self-assigned this Jan 21, 2020
@Deantwo
Added new AsteriskVersions to determineVersion()
3adadb1 
Added up to Asterisk v17.
Added an attempt at getting newer versions too.
@Deantwo
Fixed possible Regex error
efc6a4d
@Deantwo

Deantwo commented Jan 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

I don't understand how "Asterisk 16.6.2 built by mockbuild @ jenkins7 on a x86_64 running Linux on 2019-11-22 00:56:40 UTC" didn't cause the determineVersion() method to throw an exception.

@Deantwo Deantwo marked this pull request as ready for review January 21, 2020 11:37
@Deantwo Deantwo requested a review from skrusty January 21, 2020 11:38
@Deantwo

Deantwo commented Jan 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Would love it if someone could test it against a newer (>v14) Asterisk version. I don't have one myself.

@Deantwo Deantwo changed the title Support for newer Asterisk versions Fixes to determining Asterisk version Jan 21, 2020
@Deantwo

Deantwo commented Jan 21, 2020 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Regex test:

Asterisk 1.4.25.1 built by root @ achilles.pv.pikatech.com on a i686 running Linux on 2010-10-22 15:22:48 UTC
Asterisk 1.8.21.0 built by root @ jenkins-el6-32.schmoozecom.net on a i686 running Linux on 2013-03-29 19:25:55 UTC
Asterisk 11.14.1 built by root @ jenkins-builder1.schmoozecom.net on a x86_64 running Linux on 2014-11-20 23:05:28 UTC
Asterisk 16.6.2 built by mockbuild @ jenkins7 on a x86_64 running Linux on 2019-11-22 00:56:40 UTC

https://regex101.com/r/lj81Y0/1

@Deantwo Deantwo linked an issue Feb 6, 2020 that may be closed by this pull request
Multiple variables set in Orignate AMI action are merged/joined #220
Open
@Deantwo Deantwo mentioned this pull request Feb 6, 2020
Closed
@Deantwo Deantwo linked an issue Feb 6, 2020 that may be closed by this pull request
Passing multiple variables #202
Closed
@Deantwo Deantwo added this to the Version 1.4 milestone Feb 10, 2020
@Deantwo Deantwo mentioned this pull request Apr 21, 2021
Closed
@Deantwo Deantwo merged commit aa16f17 into AsterNET-1.x Apr 23, 2021
@Deantwo Deantwo deleted the NewAsteriskVersions branch April 23, 2021 08:43
This was referenced Apr 23, 2021
Closed
Merged
@Deantwo Deantwo mentioned this pull request Sep 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skrusty skrusty Awaiting requested review from skrusty

Assignees

@Deantwo Deantwo

Labels

bug A bug in the project that needs to be fixed.

Projects

None yet

Milestone

Version 1.4

Development

Successfully merging this pull request may close these issues.

Multiple variables set in Orignate AMI action are merged/joined Passing multiple variables

1 participant

@Deantwo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.