Add references in summaries to asterisk docs (manager > actions)#176
Open
moldypenguins wants to merge 2 commits into
AsterNET:masterAsterNET/AsterNET:masterfrom
moldypenguins:DocManagerActionmoldypenguins/AsterNET:DocManagerActionCopy head branch name to clipboard
Open
Add references in summaries to asterisk docs (manager > actions)#176moldypenguins wants to merge 2 commits intoAsterNET:masterAsterNET/AsterNET:masterfrom moldypenguins:DocManagerActionmoldypenguins/AsterNET:DocManagerActionCopy head branch name to clipboard
moldypenguins wants to merge 2 commits into
AsterNET:masterAsterNET/AsterNET:masterfrom
moldypenguins:DocManagerActionmoldypenguins/AsterNET:DocManagerActionCopy head branch name to clipboard
Conversation
Contributor
Author
|
See issue #157 Add Links to Documentation |
Contributor
Author
|
will go through these to add line breaks and remove extra white space |
Collaborator
|
looks good! |
Deantwo
requested changes
Oct 10, 2019
Deantwo
left a comment
Collaborator
There was a problem hiding this comment.
There are missing some <br/> tags for newlines.
Some of all the new GitHub changes makes reviewing these pull requests a lot easier.
So if these are fixed it shouldn't be too hard to review it again.
Comment on lines
-32
to
+37
| string chargingrAssociationPlan) | ||
| string chargingAssociationPlan) |
Collaborator
There was a problem hiding this comment.
Why was this parameter renamed?
Collaborator
There was a problem hiding this comment.
Is this is a bug fix in the middle of a documentation pull request?
According to Asterisk 14 ManagerAction_AOCMessage, it should indeed be chargingAssociationPlan.
Please keep a pull request on-topic. Looking for minor bug fixes in the middle of a huge documentation change is how bugs happen.
Comment on lines
10
to
+13
| /// Available since Asterisk 1.2 | ||
| /// | ||
| /// Deprecated in Asterisk 1.4 | ||
| /// Removed in Asterisk 1.6 |
Comment on lines
+4
to
+9
| /// Starts recording a specified conference, with an optional filename. | ||
| /// If recording is already in progress, an error will be returned. | ||
| /// If RecordFile is not provided, the default record_file as specified in the conferences Bridge Profile will be used. | ||
| /// If record_file is not specified, a file will automatically be generated in Asterisk's monitor directory. | ||
| /// | ||
| /// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeStartRecord">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeStartRecord</see> |
Comment on lines
+4
to
+8
| /// Creates an empty file in the configuration directory. | ||
| /// This action will create an empty file in the configuration directory. This action is intended to be used before an | ||
| /// UpdateConfig action. | ||
| /// | ||
| /// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_CreateConfig">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_CreateConfig</see> |
Comment on lines
+4
to
+7
| /// Creates a new DBDelAction that deletes the value of the database entry | ||
| /// with the given key in the given family. | ||
| /// | ||
| /// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_DBDel">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_DBDel</see> |
Comment on lines
+5
to
+6
| /// | ||
| /// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeSetSingleVideoSrc">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeSetSingleVideoSrc</see> |
Comment on lines
+5
to
+6
| /// | ||
| /// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeStopRecord">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeStopRecord</see> |
Comment on lines
+5
to
+6
| /// | ||
| /// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeUnlock">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeUnlock</see> |
Comment on lines
+5
to
+6
| /// | ||
| /// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeUnmute">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_ConfbridgeUnmute</see> |
Comment on lines
+5
to
+6
| /// | ||
| /// See <see target="_blank" href="https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_CoreSettings">https://wiki.asterisk.org/wiki/display/AST/Asterisk+16+ManagerAction_CoreSettings</see> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.