Fix bug: Encoding.UTF8 caused Unhandled exception#116
Merged
Merged
Fix bug: Encoding.UTF8 caused Unhandled exception#116
Conversation
Deantwo
reviewed
Oct 17, 2017
| { | ||
| writer.Write(s); | ||
| writer.Write(encoding.GetBytes(s)); | ||
| writer.Flush(); |
Collaborator
There was a problem hiding this comment.
Why is this the only line with spaces instead of tabs?
Not a big issue, just makes reading the code on GitHub weird.
Author
There was a problem hiding this comment.
Visual Studio Text Editor. I have nothing to do with =)
Collaborator
There was a problem hiding this comment.
I know. There are other places in this project where this is an issue, and it is really just annoying to read. Other than that, it really doesn't matter. ^^;
added 3 commits
October 18, 2017 16:35
skrusty
approved these changes
Oct 26, 2017
This was referenced Apr 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix of this issue: #22