Empty layouts w/o styling + Readme typo/grammatical fixes#937
Open
chaneylc wants to merge 5 commits into
Open
Empty layouts w/o styling + Readme typo/grammatical fixes#937chaneylc wants to merge 5 commits into
chaneylc wants to merge 5 commits into
Conversation
Just some grammatical fixes.
Updated basic usage to add app intro style.
Author
|
I added a styling guide based on the example to the basic usage section. I ran into an issue with my application where the app intro fragment would be completely blank, following your basic usage guide. Defining the example app intro style and adding it to the manifest fixed this issue. |
cortinico
reviewed
May 19, 2021
Comment on lines
+109
to
+116
| Next, define your app intro theme in res/values/styles.xml. | ||
| ``` | ||
| <style name="AppIntroTheme" parent="Theme.AppCompat.NoActionBar"> | ||
| <item name="colorPrimary">#F57C00</item> | ||
| <item name="colorPrimaryDark">#212121</item> | ||
| <item name="colorAccent">#F57C00</item> | ||
| </style> | ||
| ``` |
Member
There was a problem hiding this comment.
I won't add this into the README honestly. While I understand this fixed your issue, this is not a required step for all of our users.
Member
|
Thanks for fixing the typos. Those are valid and should be added. The layout sample should probably be included in the sample app, maybe we can add some more documentation there. |
Member
|
Hey @chaneylc Can you please follow up on the comments I left? Or let me know and I'll edit and land this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some subtle fixes for the README.