Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Sign-off commits - #2694

#2694
Merged
martincostello merged 1 commit into
mainApp-vNext/Polly:mainfrom
sign-off-commitsApp-vNext/Polly:sign-off-commitsCopy head branch name to clipboard
Aug 11, 2025
Merged

Sign-off commits#2694
martincostello merged 1 commit into
mainApp-vNext/Polly:mainfrom
sign-off-commitsApp-vNext/Polly:sign-off-commitsCopy head branch name to clipboard

Conversation

@martincostello

Copy link
Copy Markdown
Member

Add the Signed-off-by trailer to Git commits.

Add the `Signed-off-by` trailer to Git commits.
Copilot AI review requested due to automatic review settings August 11, 2025 15:11
@martincostello martincostello added enhancement github_actions Pull requests that update GitHub Actions code labels Aug 11, 2025
@martincostello
martincostello enabled auto-merge (rebase) August 11, 2025 15:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the Signed-off-by trailer to Git commits by including the -s flag in git commit commands across GitHub workflow files. This ensures that all automated commits include proper sign-off information as required by many open source projects.

  • Added -s flag to git commit commands in GitHub Actions workflows
  • Ensures automated commits include Signed-off-by trailers for compliance

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/on-push-do-docs.yml Added sign-off flag to documentation update commits
.github/workflows/after-release.yml Added sign-off flag to changelog update commits

@codecov

codecov Bot commented Aug 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.23%. Comparing base (10be2ed) to head (7037d36).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2694   +/-   ##
=======================================
  Coverage   96.23%   96.23%           
=======================================
  Files         311      311           
  Lines        7322     7322           
  Branches     1012     1012           
=======================================
  Hits         7046     7046           
  Misses        222      222           
  Partials       54       54           
Flag Coverage Δ
linux 96.23% <ø> (ø)
macos 96.23% <ø> (ø)
windows 96.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
martincostello merged commit 2208705 into main Aug 11, 2025
27 checks passed
@martincostello
martincostello deleted the sign-off-commits branch August 11, 2025 15:21
This was referenced Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.