Fix package signing - #2631
#2631Merged
Merged
Conversation
Use a federated credential to access Azure Key Vault for the code-signing certificate instead of the now-expired secrets.
- Remove all permissions by default. - Add `contents: read` for building the packages. - Add `id-token: write` to sign the packages.
martincostello
commented
Jun 1, 2025
martincostello
commented
Jun 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2631 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 311 311
Lines 7329 7329
Branches 1013 1013
=======================================
Hits 7053 7053
Misses 222 222
Partials 54 54
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
commented
Jun 4, 2025
See if it works anyway.
martincostello
commented
Jun 4, 2025
Doesn't work without it either.
martincostello
commented
Jun 4, 2025
Switch to `IDENTITY` instead of `SERVICE_PRINCIPAL`.
martincostello
commented
Jun 4, 2025
That wasn't the problem.
martincostello
marked this pull request as ready for review
June 5, 2025 17:15
martincostello
enabled auto-merge (squash)
June 5, 2025 17:15
This was referenced Nov 24, 2025
Open
This was referenced Jul 8, 2026
This was referenced Jul 16, 2026
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a federated credential to access Azure Key Vault for the code-signing certificate instead of the now-expired secrets.