Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Improve coverage - #2526

#2526
Merged
martincostello merged 6 commits into
mainApp-vNext/Polly:mainfrom
kill-mutantsApp-vNext/Polly:kill-mutantsCopy head branch name to clipboard
Feb 21, 2025
Merged

Improve coverage#2526
martincostello merged 6 commits into
mainApp-vNext/Polly:mainfrom
kill-mutantsApp-vNext/Polly:kill-mutantsCopy head branch name to clipboard

Conversation

@martincostello

@martincostello martincostello commented Feb 21, 2025

Copy link
Copy Markdown
Member

- Add missing coverage identified by #2524.
- Avoid allocating empty delegates.
- Fix-up some formatting.
- Remove redundant code.
@martincostello martincostello added CI/build .NET Pull requests that update .NET code labels Feb 21, 2025
@codecov

codecov Bot commented Feb 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 97.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.23%. Comparing base (4083d90) to head (5b47c88).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...cuitBreaker/AdvancedCircuitBreakerTResultSyntax.cs 85.71% 1 Missing ⚠️
...reaker/AsyncAdvancedCircuitBreakerTResultSyntax.cs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2526      +/-   ##
==========================================
+ Coverage   94.22%   96.23%   +2.00%     
==========================================
  Files         311      311              
  Lines        7413     7327      -86     
  Branches     1038     1013      -25     
==========================================
+ Hits         6985     7051      +66     
+ Misses        335      222     -113     
+ Partials       93       54      -39     
Flag Coverage Δ
linux 96.23% <97.77%> (+2.00%) ⬆️
macos 96.23% <97.77%> (+2.00%) ⬆️
windows 96.22% <97.72%> (+2.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Add some missing coverage identified in #2525.
- Remove dead code.
- Increase coverage threshold for Polly.Specs.
Fix `SA1129` warning from using default constructor on value type.
Fix inverted values.
Add missing coverage for files changed.
Increase coverage thresholds for Polly.Specs.
@martincostello
martincostello marked this pull request as ready for review February 21, 2025 18:57
@martincostello
martincostello enabled auto-merge (squash) February 21, 2025 18:58
@martincostello
martincostello merged commit 3fb0897 into main Feb 21, 2025
@martincostello
martincostello deleted the kill-mutants branch February 21, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/build .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Morty Proxy This is a proxified and sanitized view of the page, visit original site.