Lint PowerShell scripts - #2504
#2504Merged
Merged
Conversation
- Add a PowerShell linter. - Fix PowerShell lint warnings. - Update actionlint to v1.7.7.
- Fix PowerShell lint warnings in workflows.
- Use `${env:}` for consistency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2504 +/- ##
=======================================
Coverage 85.35% 85.36%
=======================================
Files 312 312
Lines 7465 7468 +3
Branches 1121 1121
=======================================
+ Hits 6372 6375 +3
Misses 908 908
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Use environment variables in inline scripts instead of using interpolation to avoid script injection. - Tighten-up some of the default GitHub token permissions.
Fix PowerShell syntax in bash command.
There was a problem hiding this comment.
Copilot reviewed 5 out of 16 changed files in this pull request and generated no comments.
Files not reviewed (11)
- .github/workflows/actions-lint.yml: Language not supported
- bench/benchmarks.ps1: Language not supported
- build.ps1: Language not supported
- eng/bump-version.ps1: Language not supported
- eng/update-changelog.ps1: Language not supported
- .github/workflows/on-push-do-docs.yml: Evaluated as low risk
- .github/workflows/after-release.yml: Evaluated as low risk
- .github/workflows/dependency-review.yml: Evaluated as low risk
- .github/workflows/nuget-packages-published.yml: Evaluated as low risk
- .github/workflows/update-dotnet-sdk.yml: Evaluated as low risk
- .github/workflows/stale.yml: Evaluated as low risk
martincostello
marked this pull request as ready for review
February 15, 2025 15:11
martincostello
enabled auto-merge (squash)
February 15, 2025 15:11
This was referenced Nov 24, 2025
Open
This was referenced Dec 8, 2025
This was referenced Dec 15, 2025
This was referenced Jul 8, 2026
This was referenced Jul 16, 2026
This was referenced Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.