Cleanup the Polly and Polly.Specs codebase - #2467
#2467Merged
martincostello merged 10 commits intoJan 28, 2025
Merged
Conversation
Apply remaining IDE suggestions for code simplification and clean-up in Polly.Specs.
- Suppress extant occurrences of S2223. - Re-enable S2223.
- Suppress extant occurrences of CA1051. - Enable CA1051.
- Suppress extant occurrences of CA1724. - Re-enable CA1724.
- Suppress extant occurrence of CA1064. - Re-enable CA1064.
- Suppress extant occurrences of CA1031. - Re-enable CA1031.
- Suppress extant occurrences of CA1063. - Re-enable CA1063.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
=======================================
Coverage 85.35% 85.35%
=======================================
Files 312 312
Lines 7464 7465 +1
Branches 1121 1121
=======================================
+ Hits 6371 6372 +1
Misses 908 908
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fix IDE0055 warnings on Windows.
martincostello
marked this pull request as ready for review
January 28, 2025 10:54
martincostello
enabled auto-merge (rebase)
January 28, 2025 10:54
This was referenced Jul 30, 2025
This was referenced Jul 7, 2026
This was referenced Jul 15, 2026
This was referenced Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1290.