Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Update signing workflow - #2323

#2323
Merged
martincostello merged 2 commits into
mainApp-vNext/Polly:mainfrom
update-signingApp-vNext/Polly:update-signingCopy head branch name to clipboard
Oct 1, 2024
Merged

Update signing workflow#2323
martincostello merged 2 commits into
mainApp-vNext/Polly:mainfrom
update-signingApp-vNext/Polly:update-signingCopy head branch name to clipboard

Conversation

@martincostello

@martincostello martincostello commented Oct 1, 2024

Copy link
Copy Markdown
Member
  • Update AuthenticodeLint to a version targeting .NET 8.
  • Set environment variables for Azure Key Vault to use with future versions of the sign tool.

Tested in #2322.

@martincostello
Update AuthenticodeLint
9bddef6 
Update to a version targeting .NET 8.
@martincostello
Set env vars for sign
23e17ac 
Set environment variables for Azure Key Vault to use with future versions of the `sign` tool.
@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code github_actions Pull requests that update GitHub Actions code labels Oct 1, 2024
@martincostello martincostello added this to the v8.4.3 milestone Oct 1, 2024
@martincostello
martincostello enabled auto-merge (rebase) October 1, 2024 11:58
@codecov

codecov Bot commented Oct 1, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (0969c55) to head (23e17ac).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2323   +/-   ##
=======================================
  Coverage   85.39%   85.39%           
=======================================
  Files         313      313           
  Lines        7461     7461           
  Branches     1126     1126           
=======================================
  Hits         6371     6371           
  Misses        745      745           
  Partials      345      345
Flag Coverage Δ
linux 85.39% <ø> (+0.02%) ⬆️
macos 85.36% <ø> (-0.03%) ⬇️
windows 85.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
martincostello merged commit 056b27c into main Oct 1, 2024
@martincostello
martincostello deleted the update-signing branch October 1, 2024 12:41
This was referenced Jul 22, 2025
Closed
Closed
Closed
This was referenced Jul 30, 2025
Closed
Merged
Closed
Closed
Closed
Merged
@dependabot dependabot Bot mentioned this pull request Aug 6, 2025
Closed
This was referenced Aug 18, 2025
Closed
Closed
Closed
This was referenced Aug 26, 2025
Closed
Closed
This was referenced Sep 2, 2025
Closed
Closed
This was referenced Sep 22, 2025
Closed
Closed
This was referenced Jan 19, 2026
Merged
Merged
Merged
This was referenced Jan 29, 2026
Closed
Merged
@dependabot dependabot Bot mentioned this pull request Feb 16, 2026
Merged
@dependabot dependabot Bot mentioned this pull request Feb 24, 2026
Closed
This was referenced Mar 5, 2026
Merged
Merged
This was referenced Mar 16, 2026
Open
Closed
This was referenced Mar 26, 2026
Merged
Open
Open
Closed
@dependabot dependabot Bot mentioned this pull request Apr 7, 2026
Open
This was referenced Apr 20, 2026
Merged
Merged
Merged
@dependabot dependabot Bot mentioned this pull request Apr 28, 2026
Merged
This was referenced May 11, 2026
Merged
Closed
This was referenced May 24, 2026
Closed
Merged
This was referenced Jun 15, 2026
Closed
Open
Closed
@dependabot dependabot Bot mentioned this pull request Jul 1, 2026
Open
@dependabot dependabot Bot mentioned this pull request Jul 15, 2026
Open
@dependabot dependabot Bot mentioned this pull request Jul 27, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file enhancement github_actions Pull requests that update GitHub Actions code .NET Pull requests that update .NET code

Projects

None yet

Milestone

v8.5.0

Development

Successfully merging this pull request may close these issues.

1 participant

@martincostello
Morty Proxy This is a proxified and sanitized view of the page, visit original site.