Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix warning CA1062#ISyncPolicyPolicyWrapExtensions - #2230

#2230
Merged
martincostello merged 3 commits into
App-vNext:mainApp-vNext/Polly:mainfrom
Zombach:zombach/remove-warning-ca1062#i-sync-policy-policy-wrap-extensionsZombach/Polly:zombach/remove-warning-ca1062#i-sync-policy-policy-wrap-extensionsCopy head branch name to clipboard
Jul 23, 2024
Merged

Fix warning CA1062#ISyncPolicyPolicyWrapExtensions#2230
martincostello merged 3 commits into
App-vNext:mainApp-vNext/Polly:mainfrom
Zombach:zombach/remove-warning-ca1062#i-sync-policy-policy-wrap-extensionsZombach/Polly:zombach/remove-warning-ca1062#i-sync-policy-policy-wrap-extensionsCopy head branch name to clipboard

Conversation

@Zombach

@Zombach Zombach commented Jul 22, 2024

Copy link
Copy Markdown
Contributor

Pull Request

The issue or feature being addressed

#2215

Details on the issue fix or feature implementation

  • Suppress CA1062 in src/Polly/Wrap/ISyncPolicyPolicyWrapExtensions.cs or fix the warning

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature

@codecov

codecov Bot commented Jul 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (72331dc) to head (8dbd02a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2230      +/-   ##
==========================================
+ Coverage   84.00%   84.01%   +0.01%     
==========================================
  Files         313      313              
  Lines        7227     7233       +6     
  Branches     1078     1080       +2     
==========================================
+ Hits         6071     6077       +6     
  Misses        785      785              
  Partials      371      371              
Flag Coverage Δ
linux 84.01% <100.00%> (+0.01%) ⬆️
macos 84.01% <100.00%> (+0.01%) ⬆️
windows 84.01% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
martincostello merged commit f054ef7 into App-vNext:main Jul 23, 2024
@Zombach
Zombach deleted the zombach/remove-warning-ca1062#i-sync-policy-policy-wrap-extensions branch July 23, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.