Warning Suppression CA1062 - #2216
#2216Warning Suppression CA1062#2216martincostello merged 1 commit intoApp-vNext:mainApp-vNext/Polly:mainfrom Zombach:zombach/remove-warning-ca1062Zombach/Polly:zombach/remove-warning-ca1062Copy head branch name to clipboard
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2216 +/- ##
=======================================
Coverage 83.89% 83.89%
=======================================
Files 313 313
Lines 7179 7179
Branches 1060 1060
=======================================
Hits 6023 6023
Misses 785 785
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Why suppress rather than fix in this case? |
The problem is that there is a lot of this warning. And if you do not suppress this warning in advance. If you disable this warning, a lot of noise is created. Which is very much in the way. And when correcting the warning, it is necessary to additionally cover the code with tests. Which in turn amounts to a huge PR of 1000+ lines. That's why I divided the task into subtasks, as described in #2215 . And now anyone can take a file as a separate file, disable warning suppression in it and fully work it out. Without making too much noise. |
Pull Request
The issue or feature being addressed
#2215
Details on the issue fix or feature implementation
Confirm the following