Fix SA1615/SA1623 warnings - #2091
#2091Merged
Merged
Fix SA1615/SA1623 warnings#2091
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2091 +/- ##
=======================================
Coverage 83.72% 83.72%
=======================================
Files 312 312
Lines 7126 7126
Branches 1054 1054
=======================================
Hits 5966 5966
Misses 789 789
Partials 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Noticed that SA1623 can be fixed without suppressing rule. Will push new changes. |
iamdmitrij
commented
May 2, 2024
Contributor
Author
|
SA1623 is now fixed without |
martincostello
approved these changes
May 2, 2024
Co-authored-by: Martin Costello <martin@martincostello.com>
martincostello
enabled auto-merge (squash)
May 2, 2024 15:57
Member
|
Thanks again! |
This was referenced Jul 30, 2025
This was referenced Aug 26, 2025
This was referenced Sep 29, 2025
This was referenced Dec 8, 2025
This was referenced Jan 16, 2026
This was referenced Mar 5, 2026
This was referenced Mar 26, 2026
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
#1290
Details on the issue fix or feature implementation
Gets/SetsConfirm the following