Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix CA1000/S4023/S3442/S107/SA1402/SA1649 warnings - #2089

#2089
Merged
martincostello merged 29 commits into
App-vNext:mainApp-vNext/Polly:mainfrom
iamdmitrij:mainiamdmitrij/Polly:mainCopy head branch name to clipboard
May 1, 2024
Merged

Fix CA1000/S4023/S3442/S107/SA1402/SA1649 warnings#2089
martincostello merged 29 commits into
App-vNext:mainApp-vNext/Polly:mainfrom
iamdmitrij:mainiamdmitrij/Polly:mainCopy head branch name to clipboard

Conversation

@iamdmitrij

@iamdmitrij iamdmitrij commented Apr 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Pull Request

The issue or feature being addressed

#1290

  • Enable CA1000 check only for non-public types
  • Make S4023 a suggestion
  • Fix S3442 by making abstract classes constructors private
  • Set S107 max param count to 12
  • Disable SA1402 because this repo doesn't follow such file/class structure
  • Fix SA1649 by consolidating class/file names. As far as I can tell it doesn't break any public APIs, just renaming C# source files
  • Add eng/analyzers configs to solution file in Solution Items

Details on the issue fix or feature implementation

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

iamdmitrij added 29 commits April 25, 2024 23:33
@iamdmitrij
Fix SA1618 by documenting typeparams
84518b8 
https://github.com/DotNetAnalyzers/StyleCopAnalyzers/blob/master/documentation/SA1618.md
@iamdmitrij
Consolidate typeparam text
f32222b
@iamdmitrij
Enable S6605
e013fa4
@iamdmitrij
Disable S3253
f21b783
@iamdmitrij
Fix SA1625
ee0f007
@iamdmitrij
Merge branch 'App-vNext:main' into main
fb9510a
@iamdmitrij
Merge branch 'App-vNext:main' into main
ce1c4e8
@iamdmitrij
Fix S103
62ecd4a
@iamdmitrij
Merge pull request #1 from iamdmitrij/S6605
265f0ac 
Fix S3253& S6605
@iamdmitrij
Merge pull request #3 from iamdmitrij/S103
76da73f 
Fix S103
@iamdmitrij
Merge branch 'main' into SA1625
4bd777f
@iamdmitrij
Add new line
aad9e03
@iamdmitrij
Revert auto formatting
c4c77ee
@iamdmitrij
Revert formatted files
f8eecf3
@iamdmitrij
Merge pull request #2 from iamdmitrij/SA1625
7f58bec 
Fix SA1625
@iamdmitrij
Fix ArgumentNullException doc reference to onTimeoutAsync param
fdb1b27
@iamdmitrij
Fix ArgumentOutOfRangeException doc reference to maxQueuingActions
4c34715
@iamdmitrij
Merge branch 'main' into main
b8cd4e8
@iamdmitrij
Consolidate exception docs in AsyncTimeoutSyntax
f835153
@iamdmitrij
Merge branch 'main' of github.com:iamdmitrij/Polly
972943d
@iamdmitrij
Fix S107
0154cbf
@iamdmitrij
Fix CA1000
7d5c0ad
@iamdmitrij
Add new line
60d5060
@iamdmitrij
Fix S4023
ec5314e
@iamdmitrij
Merge pull request #6 from iamdmitrij/S4023
b502fe8 
Fix S4023
@iamdmitrij
Merge pull request #5 from iamdmitrij/CA1000
558d932 
Fix CA1000
@iamdmitrij
Fix SA1649 (#9)
950e7ef
@iamdmitrij
Fix SA1402 (#10)
0ddf2cc 
* Fix SA1402

* Update .editorconfig

* Update .editorconfig
@iamdmitrij
Fix S3442 (#8)
a6acc1a 
* Fix S3442

* Fix linting error
@codecov

codecov Bot commented Apr 30, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.72%. Comparing base (3c642fd) to head (a6acc1a).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2089   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files         312      312           
  Lines        7126     7126           
  Branches     1054     1054           
=======================================
  Hits         5966     5966           
  Misses        789      789           
  Partials      371      371
Flag Coverage Δ
linux 83.72% <100.00%> (?)
macos 83.72% <100.00%> (?)
windows 83.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dependabot dependabot Bot mentioned this pull request Aug 5, 2025
Merged
@dependabot dependabot Bot mentioned this pull request Aug 18, 2025
Closed
This was referenced Aug 26, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Sep 2, 2025
Closed
This was referenced Sep 29, 2025
Open
Closed
Closed
Merged
@dependabot dependabot Bot mentioned this pull request Oct 27, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Nov 24, 2025
Open
This was referenced Dec 8, 2025
Open
Closed
@dependabot dependabot Bot mentioned this pull request Dec 15, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Jan 1, 2026
Open
This was referenced Jan 16, 2026
Closed
Merged
Merged
@dependabot dependabot Bot mentioned this pull request Jan 29, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Feb 16, 2026
Merged
This was referenced Mar 5, 2026
Merged
Merged
This was referenced Mar 26, 2026
Merged
Open
Closed
@dependabot dependabot Bot mentioned this pull request Apr 20, 2026
Merged
This was referenced May 11, 2026
Merged
Closed
@dependabot dependabot Bot mentioned this pull request Jun 15, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jul 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martincostello martincostello martincostello approved these changes

Assignees

No one assigned

Labels

CI/build

Projects

None yet

Milestone

v8.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@iamdmitrij @martincostello
Morty Proxy This is a proxified and sanitized view of the page, visit original site.