Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix IDE0011 warning - #2085

#2085
Merged
martincostello merged 13 commits into
App-vNext:mainApp-vNext/Polly:mainfrom
iamdmitrij:IDE0011iamdmitrij/Polly:IDE0011Copy head branch name to clipboard
Apr 29, 2024
Merged

Fix IDE0011 warning#2085
martincostello merged 13 commits into
App-vNext:mainApp-vNext/Polly:mainfrom
iamdmitrij:IDE0011iamdmitrij/Polly:IDE0011Copy head branch name to clipboard

Conversation

@iamdmitrij

Copy link
Copy Markdown
Contributor

Pull Request

The issue or feature being addressed

#1290

Details on the issue fix or feature implementation

  • Added braces to if/while statements
  • Disabled IDE0011 warning suppression

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@iamdmitrij iamdmitrij changed the title Fix IDE0011 Fix IDE0011 warning Apr 29, 2024
@codecov

codecov Bot commented Apr 29, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (08d7bc4) to head (3c4e6bd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2085      +/-   ##
==========================================
+ Coverage   83.69%   83.70%   +0.01%     
==========================================
  Files         312      312              
  Lines        7114     7120       +6     
  Branches     1054     1054              
==========================================
+ Hits         5954     5960       +6     
  Misses        789      789              
  Partials      371      371              
Flag Coverage Δ
linux 83.70% <100.00%> (+0.01%) ⬆️
macos 83.70% <100.00%> (?)
windows 83.70% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iamdmitrij
iamdmitrij marked this pull request as ready for review April 29, 2024 11:19
@martincostello martincostello added this to the v8.4.0 milestone Apr 29, 2024
@martincostello
martincostello enabled auto-merge (squash) April 29, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.