Remove async void usage - #2013
#2013Merged
martincostello merged 1 commit intoMar 7, 2024
App-vNext:mainApp-vNext/Polly:mainfrom
martincostello:remove-async-voidmartincostello/Polly:remove-async-voidCopy head branch name to clipboard
Merged
Remove async void usage#2013martincostello merged 1 commit intoApp-vNext:mainApp-vNext/Polly:mainfrom martincostello:remove-async-voidmartincostello/Polly:remove-async-voidCopy head branch name to clipboard
martincostello merged 1 commit into
App-vNext:mainApp-vNext/Polly:mainfrom
martincostello:remove-async-voidmartincostello/Polly:remove-async-voidCopy head branch name to clipboard
Conversation
Remove tests using `async void` that shouldn't be.
martincostello
enabled auto-merge (rebase)
March 7, 2024 19:04
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2013 +/- ##
=======================================
Coverage 83.64% 83.64%
=======================================
Files 312 312
Lines 7105 7105
Branches 1054 1054
=======================================
Hits 5943 5943
Misses 789 789
Partials 373 373
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Jul 30, 2025
This was referenced Aug 26, 2025
This was referenced Sep 29, 2025
This was referenced Dec 8, 2025
This was referenced Jan 16, 2026
This was referenced Mar 5, 2026
This was referenced Mar 26, 2026
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove tests using
async voidthat shouldn't be.dotnet/extensions#4985 (comment)