Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix S3717 - #1965

#1965
Merged
martincostello merged 1 commit into
App-vNext:mainApp-vNext/Polly:mainfrom
gintsk:fix-s3717gintsk/Polly:fix-s3717Copy head branch name to clipboard
Feb 10, 2024
Merged

Fix S3717#1965
martincostello merged 1 commit into
App-vNext:mainApp-vNext/Polly:mainfrom
gintsk:fix-s3717gintsk/Polly:fix-s3717Copy head branch name to clipboard

Conversation

@gintsk

@gintsk gintsk commented Feb 10, 2024

Copy link
Copy Markdown
Contributor

Pull Request

The issue or feature being addressed

Contributes to #1290

Details on the issue fix or feature implementation

Fix S3717

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov

codecov Bot commented Feb 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2ad40a8) 85.91% compared to head (d170b35) 85.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1965   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         312      312           
  Lines        6654     6654           
  Branches     1057     1057           
=======================================
  Hits         5717     5717           
  Misses        540      540           
  Partials      397      397           
Flag Coverage Δ
linux 85.91% <ø> (ø)
macos 85.91% <ø> (ø)
windows 85.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello added this to the v8.3.1 milestone Feb 10, 2024
@martincostello
martincostello enabled auto-merge (squash) February 10, 2024 09:58
@martincostello
martincostello merged commit c8c1890 into App-vNext:main Feb 10, 2024
@gintsk
gintsk deleted the fix-s3717 branch February 12, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.