Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Fix CA1806 - #1963

#1963
Merged
martincostello merged 3 commits into
App-vNext:mainApp-vNext/Polly:mainfrom
gintsk:cleanupgintsk/Polly:cleanupCopy head branch name to clipboard
Feb 8, 2024
Merged

Fix CA1806#1963
martincostello merged 3 commits into
App-vNext:mainApp-vNext/Polly:mainfrom
gintsk:cleanupgintsk/Polly:cleanupCopy head branch name to clipboard

Conversation

@gintsk

@gintsk gintsk commented Feb 8, 2024

Copy link
Copy Markdown
Contributor

Pull Request

The issue or feature being addressed

Contributes to #1290

Details on the issue fix or feature implementation

Formal fix for CA1806: Do not ignore method results

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

martincostello
martincostello reviewed Feb 8, 2024
View reviewed changes
Comment thread test/Polly.Specs/Caching/AbsoluteTtlSpecs.cs
@codecov

codecov Bot commented Feb 8, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f40164) 85.91% compared to head (479df20) 85.91%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1963   +/-   ##
=======================================
  Coverage   85.91%   85.91%           
=======================================
  Files         312      312           
  Lines        6654     6654           
  Branches     1057     1057           
=======================================
  Hits         5717     5717           
  Misses        540      540           
  Partials      397      397
Flag Coverage Δ
linux 85.91% <ø> (ø)
macos 85.91% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
martincostello enabled auto-merge (squash) February 8, 2024 21:23
@martincostello

martincostello commented Feb 8, 2024

Copy link
Copy Markdown
Member

Thanks again!

@martincostello martincostello added this to the v8.3.1 milestone Feb 8, 2024
@martincostello
martincostello merged commit 29086a3 into App-vNext:main Feb 8, 2024
@gintsk
gintsk deleted the cleanup branch February 8, 2024 21:50
@dependabot dependabot Bot mentioned this pull request Aug 1, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Aug 18, 2025
Closed
This was referenced Aug 26, 2025
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Sep 2, 2025
Closed
This was referenced Sep 29, 2025
Open
Closed
Closed
Merged
@dependabot dependabot Bot mentioned this pull request Oct 27, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Nov 24, 2025
Open
This was referenced Dec 8, 2025
Open
Closed
@dependabot dependabot Bot mentioned this pull request Dec 15, 2025
Closed
@dependabot dependabot Bot mentioned this pull request Jan 1, 2026
Open
This was referenced Jan 16, 2026
Closed
Merged
This was referenced Jan 22, 2026
Merged
Closed
@dependabot dependabot Bot mentioned this pull request Feb 16, 2026
Merged
This was referenced Mar 5, 2026
Merged
Merged
This was referenced Mar 26, 2026
Merged
Open
Closed
@dependabot dependabot Bot mentioned this pull request Apr 20, 2026
Merged
This was referenced May 11, 2026
Merged
Closed
@dependabot dependabot Bot mentioned this pull request Jun 15, 2026
Closed
@dependabot dependabot Bot mentioned this pull request Jul 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martincostello martincostello martincostello approved these changes
+1 more reviewer
@jnyrup jnyrup jnyrup left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI/build code styling clean-ups

Projects

None yet

Milestone

v8.3.1

Development

Successfully merging this pull request may close these issues.

3 participants

@gintsk @martincostello @jnyrup
Morty Proxy This is a proxified and sanitized view of the page, visit original site.