Do not encourage returning the same instance from chaos strategies - #1899
#1899Merged
martintmk merged 2 commits intoJan 15, 2024
mainApp-vNext/Polly:mainfrom
mtomka/drop-some-simmy-apisApp-vNext/Polly:mtomka/drop-some-simmy-apisCopy head branch name to clipboard
Merged
Do not encourage returning the same instance from chaos strategies#1899martintmk merged 2 commits intomainApp-vNext/Polly:mainfrom mtomka/drop-some-simmy-apisApp-vNext/Polly:mtomka/drop-some-simmy-apisCopy head branch name to clipboard
martintmk merged 2 commits into
mainApp-vNext/Polly:mainfrom
mtomka/drop-some-simmy-apisApp-vNext/Polly:mtomka/drop-some-simmy-apisCopy head branch name to clipboard
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
- Coverage 84.68% 84.66% -0.03%
==========================================
Files 309 309
Lines 6845 6833 -12
Branches 1052 1052
==========================================
- Hits 5797 5785 -12
Misses 839 839
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
martincostello
approved these changes
Jan 15, 2024
4 tasks
This was referenced Aug 26, 2025
This was referenced Sep 29, 2025
This was referenced Dec 8, 2025
This was referenced Jan 16, 2026
This was referenced Mar 5, 2026
This was referenced Mar 26, 2026
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
These overloads could lead to the same problems as in #1877. For results, returning the same cached value (i.e.
HttpResponseMessagecan also cause issues.Better not to encourage this in our APIs.
Confirm the following