Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Comments

Close side panel

Adding Preshower detector (PSR) for ALICE3 simulation#6727

Closed
an15ms157 wants to merge 21 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
an15ms157:mydevan15ms157/AliceO2:mydevCopy head branch name to clipboard
Closed

Adding Preshower detector (PSR) for ALICE3 simulation#6727
an15ms157 wants to merge 21 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
an15ms157:mydevan15ms157/AliceO2:mydevCopy head branch name to clipboard

Conversation

@an15ms157
Copy link

@an15ms157 an15ms157 commented Jul 23, 2021

This PR creates a simple 8 layered preshower detector named PSR. This is a cylindrical detector of length 100 cm whose shower layers are made up of Pb (0.5 cm) and the detector layers are made up of Si (45 microns). PSR is based on the ITSMFT classes and the code is structurally similar to that of FT3. Each layer is made of a monolithic silicon disk with a thin sensitive layer for hit generation. Silicon chip thickness is tuned to match the layer x/X0 to allow a minimal evaluation of material budget effects.

One should get a file o2sim_HitsPSR.root by running
$ o2-sim -m PSR -e TGeant3 -g boxgen -n 10

Another PR of the same name exists here which might be deleted later: #6519

@an15ms157
parent 1cd95bc
de1718d 
author Abhishek Nath <aabhishek.naath@gmail.com> 1622043714 +0200
committer Abhishek Nath <aabhishek.naath@gmail.com> 1626974584 +0200

Si-only-Preshower
@an15ms157 an15ms157 mentioned this pull request Jul 23, 2021
Closed
@mconcas
Copy link
Collaborator

mconcas commented Jul 23, 2021

Thanks. Please consider to apply this patch: patch.txt
To fix clang format test.

Cheers

mconcas
mconcas requested changes Jul 23, 2021
View reviewed changes
Copy link
Collaborator

@mconcas mconcas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, inline you find some comments. Overall seems ok.

DataFormats/Detectors/Common/include/DetectorsCommonDataFormats/DetID.h Show resolved Hide resolved
DataFormats/Detectors/Common/include/DetectorsCommonDataFormats/DetID_BACKUP_450708.h Outdated Show resolved Hide resolved
DataFormats/Detectors/Common/include/DetectorsCommonDataFormats/DetID_BASE_450708.h Outdated Show resolved Hide resolved
DataFormats/Detectors/Common/include/DetectorsCommonDataFormats/DetID_LOCAL_450708.h Outdated Show resolved Hide resolved
DataFormats/Detectors/Common/include/DetectorsCommonDataFormats/DetID_REMOTE_450708.h Outdated Show resolved Hide resolved
Detectors/Upgrades/ALICE3/FT3/simulation/src/Detector.cxx Outdated Show resolved Hide resolved
Detectors/Upgrades/ALICE3/PSR/README.md Show resolved Hide resolved
mconcas
mconcas reviewed Jul 23, 2021
View reviewed changes
Detectors/Upgrades/ALICE3/PSR/README.md Outdated Show resolved Hide resolved
mconcas
mconcas reviewed Jul 23, 2021
View reviewed changes
Detectors/Upgrades/ALICE3/PSR/README.md Outdated Show resolved Hide resolved
mconcas
mconcas reviewed Jul 23, 2021
View reviewed changes
Detectors/Upgrades/ALICE3/PSR/README.md Outdated Show resolved Hide resolved
mconcas
mconcas reviewed Jul 23, 2021
View reviewed changes
Detectors/Upgrades/ALICE3/FT3/simulation/src/Detector.cxx Outdated Show resolved Hide resolved
mconcas
mconcas reviewed Jul 23, 2021
View reviewed changes
macro/build_geometry.C Outdated Show resolved Hide resolved
an15ms157 and others added 6 commits July 23, 2021 17:02
@an15ms157
additional code removed
a3222be
@an15ms157 @mconcas
Update DataFormats/Detectors/Common/include/DetectorsCommonDataFormat…
b59d161 
…s/DetID.h

Co-authored-by: Matteo Concas <mconcas@cern.ch>
@an15ms157 @mconcas
Update Detectors/Upgrades/ALICE3/PSR/README.md
338d630 
Co-authored-by: Matteo Concas <mconcas@cern.ch>
@an15ms157 @mconcas
Update Detectors/Upgrades/ALICE3/PSR/README.md
9298213 
Co-authored-by: Matteo Concas <mconcas@cern.ch>
@an15ms157 @mconcas
Update Detectors/Upgrades/ALICE3/FT3/simulation/src/Detector.cxx
1b9f93d 
Co-authored-by: Matteo Concas <mconcas@cern.ch>
@an15ms157
Update build_geometry.C
53351a3
@an15ms157 an15ms157 requested a review from mconcas July 23, 2021 16:09
mconcas
mconcas previously approved these changes Jul 23, 2021
View reviewed changes
@an15ms157 an15ms157 dismissed stale reviews from marcovanleeuwen and mconcas via dae91fa July 27, 2021 13:54
mconcas
mconcas approved these changes Jul 27, 2021
View reviewed changes
Copy link
Collaborator

@mconcas mconcas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mconcas
Copy link
Collaborator

mconcas commented Jul 28, 2021

@sawenzel : if it is ok with you we are ready to merge

@github-actions
Copy link
Contributor

github-actions bot commented Aug 28, 2021

This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days.

@github-actions github-actions bot added the stale label Aug 28, 2021
@ktf
Copy link
Member

ktf commented Aug 30, 2021

Any reason why this is not yet merged?

@mconcas
Copy link
Collaborator

mconcas commented Aug 30, 2021 •
edited
Loading

Any reason why this is not yet merged?

As it changes the build_geometry.C macro I was interested in @sawenzel feedback.
In the meantime the inclusion of the PSR detector in O2 ALICE 3 simulation seemed to be not critical/a blocker (at least until now), so I am actually closing it for the time being to avoid unused code addition.
If it becomes relevant again I'll reopen.

@mconcas mconcas closed this Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mconcas mconcas mconcas approved these changes

@marcovanleeuwen marcovanleeuwen marcovanleeuwen left review comments

@qgp qgp Awaiting requested review from qgp

@sawenzel sawenzel Awaiting requested review from sawenzel sawenzel is a code owner

Assignees

No one assigned

Labels

stale

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@an15ms157 @mconcas @ktf @marcovanleeuwen
Morty Proxy This is a proxified and sanitized view of the page, visit original site.