Adding Preshower detector (PSR) for ALICE3 simulation#6519
Adding Preshower detector (PSR) for ALICE3 simulation#6519an15ms157 wants to merge 18 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
Please consider the following formatting changes to AliceO2Group#6519
|
ok, now that codechecker is fine the next step is to reabase your branch on the AliceO2/dev one. Since the |
|
I have made the changes. |
| // inserts the last | ||
| void MaterialManager::insertTGeoMedium(std::string modname, int localindex) | ||
| { | ||
| LOG(INFO) << "Changes for build"; |
There was a problem hiding this comment.
Perhaps a DEBUG print you forgot?
| mLayerID.clear(); | ||
| mLayers.resize(2); | ||
|
|
||
| for (Int_t direction : {0, 1}) { |
There was a problem hiding this comment.
This is not really clear to me, why these changes in FT3 whould affact the PSR? @rpezzi is it fine to you?
| \page refDetectorsUpgradesALICE3FT3 EndCaps | ||
| /doxy --> | ||
|
|
||
| # PostLS4EndCaps |
There was a problem hiding this comment.
This is minor, but I think should be changed to desccribe PSR
|
@an15ms157 : do you have any update on this? Could you also rebase on |
|
Hi @an15ms157, you should rebase the modifications you want to merge on the dev branch. The history must be linear, e.g. no merging commits and branching. Could you please do that? |
|
Hello @mconcas |
Hi @an15ms157: I had a look to your new branch and it seems to be ok, please proceed with a new PR. Thanks. |
|
This PR creates a simple 8 layered preshower detector named PSR. This is a cylindrical detector of length 100 cm whose shower layers are made up of Pb (0.5 cm) and the detector layers are made up of Si (45 microns). PSR is based on the ITSMFT classes and the code is structurally similar to that of FT3. Each layer is made of a monolithic silicon disk with a thin sensitive layer for hit generation. Silicon chip thickness is tuned to match the layer x/X0 to allow a minimal evaluation of material budget effects.
One should get a file o2sim_HitsPSR.root by running
$ o2-sim -m PSR -e TGeant3 -g boxgen -n 10