Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Comments

Close side panel

DPL Analysis: fix bug in unassigned grouping#6275

Merged
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
aalkin:fix-shiftsaalkin/AliceO2:fix-shiftsCopy head branch name to clipboard
Jun 3, 2021
Merged

DPL Analysis: fix bug in unassigned grouping#6275
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
aalkin:fix-shiftsaalkin/AliceO2:fix-shiftsCopy head branch name to clipboard

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented May 31, 2021

  • Ensure groups are correctly shifted in presence of several unassigned blocks
  • Move shifts increment from operator++ to prepareArgument() to avoid out-of-range access

@aalkin aalkin requested a review from a team as a code owner May 31, 2021 10:09
@aalkin
Copy link
Member Author

aalkin commented May 31, 2021

@jgrosseo this fixes grouping for merged AODs with unassigned tracks...

@ktf ktf merged commit d26801c into AliceO2Group:dev Jun 3, 2021
vkucera pushed a commit to vkucera/AliceO2 that referenced this pull request Jun 6, 2021
cortesep pushed a commit to cortesep/AliceO2 that referenced this pull request Jun 11, 2021
@aalkin aalkin deleted the fix-shifts branch July 21, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.