Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit d26801c

Browse filesBrowse files
authored
DPL Analysis: fix bug in unassigned grouping (#6275)
1 parent df7560b commit d26801c
Copy full SHA for d26801c

File tree

Expand file treeCollapse file tree

1 file changed

+6
-2
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

1 file changed

+6
-2
lines changed
Open diff view settings
Collapse file

‎Framework/Core/include/Framework/AnalysisTask.h‎

Copy file name to clipboardExpand all lines: Framework/Core/include/Framework/AnalysisTask.h
+6-2Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,6 @@ struct AnalysisDataProcessorBuilder {
370370
{
371371
++position;
372372
++mGroupingElement;
373-
(changeShifts<A>(), ...);
374373
return *this;
375374
}
376375

@@ -410,7 +409,12 @@ struct AnalysisDataProcessorBuilder {
410409
} else {
411410
pos = position;
412411
}
413-
pos += shifts[index];
412+
if (unassignedGroups[index] > 0) {
413+
if ((idValues[index])[pos + shifts[index]] < 0) {
414+
++shifts[index];
415+
}
416+
pos += shifts[index];
417+
}
414418
if constexpr (soa::is_soa_filtered_t<std::decay_t<A1>>::value) {
415419
auto groupedElementsTable = arrow::util::get<std::shared_ptr<arrow::Table>>(((groups[index])[pos]).value);
416420

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.