Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

RecoDecay: Improve azimuth calculations. #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Feb 23, 2021
Merged

RecoDecay: Improve azimuth calculations. #5521

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 31 additions & 12 deletions 43 Analysis/Core/include/AnalysisCore/RecoDecay.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,24 +182,43 @@ class RecoDecay
return std::atanh(mom[2] / E(mom, mass));
}

/// Calculates azimuthal angle from x and y momentum components.
/// \param px,py {x, y} momentum components
/// \return azimuthal angle
static double Phi(double px, double py)
/// Calculates azimuth from x and y components.
/// \param x,y {x, y} components
/// \return azimuth within [0, 2π]
template <typename T, typename U>
static double Phi(T x, U y)
{
// phi = pi+TMath::Atan2(-py,-px)
return (double)(o2::constants::math::PI + std::atan2(-py, -px));
// conversion from [-π, +π] returned by atan2 to [0, 2π]
Copy link
Member

@ktf ktf Feb 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, no special characters....

Copy link
Collaborator Author

@vkucera vkucera Feb 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the "π"? It should be a Unicode character. Is it not?

Copy link
Member

@ktf ktf Feb 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly...

Copy link
Collaborator Author

@vkucera vkucera Feb 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use of Unicode characters in comments is explicitly encouraged by the Coding Guidelines.
What kind of problem do you see with Unicode?

return std::atan2((double)(-y), (double)(-x)) + o2::constants::math::PI;
}

/// Calculates azimuthal angle from 3-(or 2-)momenta.
/// \param args pack of 3-(or 2-)momentum arrays
/// \return azimuthal angle
template <std::size_t N, typename T>
static double Phi(const array<T, N>& vec)
/// Calculates azimuth of a vector.
/// \note Elements 0 and 1 are expected to represent the x and y vector components, respectively.
/// \param vec vector (container of elements accessible by index)
/// \return azimuth within [0, 2π]
template <typename T>
static double Phi(const T& vec)
{
return Phi(vec[0], vec[1]);
}

/// Constrains angle to be within a range.
/// \note Inspired by TVector2::Phi_0_2pi in ROOT.
/// \param angle angle
/// \param min minimum of the range
/// \return value within [min, min + 2π).
template <typename T, typename U = float>
static T constrainAngle(T angle, U min = 0.)
{
while (angle < min) {
angle += o2::constants::math::TwoPI;
}
while (angle >= min + o2::constants::math::TwoPI) {
angle -= o2::constants::math::TwoPI;
}
return (T)angle;
}

/// Calculates cosine of pointing angle.
/// \param posPV {x, y, z} position of the primary vertex
/// \param posSV {x, y, z} position of the secondary vertex
Expand Down Expand Up @@ -331,7 +350,7 @@ class RecoDecay
}

/// Calculates (total) transverse momentum.
/// \param args {x, y} momentum components or pack of 3-momentum arrays
/// \param args {x, y} momentum components or pack of 3-(or 2-)momentum arrays
/// \return (total) transverse momentum
template <typename... T>
static double Pt(const T&... args)
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.