RecoDecay: Improve azimuth calculations.#5521
Merged
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Feb 23, 2021
Merged
RecoDecay: Improve azimuth calculations.#5521ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
ktf merged 1 commit intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
ktf
reviewed
Feb 20, 2021
| { | ||
| // phi = pi+TMath::Atan2(-py,-px) | ||
| return (double)(o2::constants::math::PI + std::atan2(-py, -px)); | ||
| // conversion from [-π, +π] returned by atan2 to [0, 2π] |
Collaborator
Author
There was a problem hiding this comment.
You mean the "π"? It should be a Unicode character. Is it not?
Collaborator
Author
There was a problem hiding this comment.
Use of Unicode characters in comments is explicitly encouraged by the Coding Guidelines.
What kind of problem do you see with Unicode?
Collaborator
Author
Collaborator
|
I don't, but I want to know if @ktf agrees because he made the comment |
Collaborator
|
btw we use mathutils in the DataModel. Is that better than std? |
Member
|
I just find unicode more difficult to parse, especially if in the end the code uses M_PI not π. Anyway, if it's in the Guidelines, it's a battle I will not fight... As long as we don't start having emojiis as variables... |
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.