Detectors are renamed - FT0 and FV0 #2278
Merged
shahor02 merged 46 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom Jul 31, 2019
Merged
Detectors are renamed - FT0 and FV0 #2278shahor02 merged 46 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
shahor02 merged 46 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
shahor02
requested changes
Jul 30, 2019
Collaborator
shahor02
left a comment
There was a problem hiding this comment.
Please see comments below. Also, either squash all commits to one, or I can do this at merging (the message of the 1st commit will be assigned)
| } | ||
|
|
||
| ///< number of validated V0 candidates (at most 2 are possible) | ||
| ///< number of validated FV0 candidates (at most 2 are possible) |
Collaborator
There was a problem hiding this comment.
I've already commented on this in the previous PR #2255 (comment), these are secondary vertices V0s, please revert this file
| double bz = 5.0; | ||
|
|
||
| // create V0 | ||
| // create FV0 |
| TVector3 startMom, double startE, | ||
| double endTime, double eLoss, Int_t particlePdg) | ||
| o2::fv0::Hit* Detector::addHit(Int_t trackId, Int_t cellId, | ||
| TVector3 startPos, TVector3 endPos, |
Collaborator
There was a problem hiding this comment.
No need to use TObject based virtual object to transfer the position/momentum, please change this to Point3D<float> or Vector3D<float>, also in related methods
| TH2S* getHistoT0(ROC roc, Bool_t force) | ||
| { | ||
| return getHistogram(roc, mT0Histograms, mNbinsT0, mXminT0, mXmaxT0, "T0", force); | ||
| return getHistogram(roc, mT0Histograms, mNbinsT0, mXminT0, mXmaxT0, "FT0", force); |
Collaborator
There was a problem hiding this comment.
This one also was commented in the prev. PR https://stackoverflow.com/questions/32766151/check-for-optionally-targets-in-cmake-that-are-not-in-the-correct-order, it is for TPC start time, revert this file please
| { | ||
| auto f = std::unique_ptr<TFile>(TFile::Open(filename.c_str(), "recreate")); | ||
| f->WriteObject(&mT0, "T0"); | ||
| f->WriteObject(&mT0, "T0"); |
Contributor
Author
There was a problem hiding this comment.
sorry, I did not check, I was sure he fixed this...
|
|
||
| enum ETrackType { | ||
| Standard, | ||
| Standard, |
Collaborator
There was a problem hiding this comment.
This one also is for secondary vertices, revert.
caac918 to
6fbc499
Compare
Contributor
Author
|
We satisfied all requests, yes? |
Collaborator
|
Hi @AllaMaevskaya |
knopers8
pushed a commit
to knopers8/AliceO2
that referenced
this pull request
Oct 23, 2019
* T0 and V0 namespace changes * clang-format fixes * T0 string changes * clang-format fixes * T0 function names, variables, file path * renaming files, directories, #includes, cmakes * more file renames, directory renames * V0 string changes * V0 comments, variables, and functions * updated V0 variable * more T0 strings, comments, and FITT0, FIT_T0 * more T0 strings, comments, and FITT0, FIT_T0 again * FIT V0 renames * lowercase t0 changes * V0 file and directory names, T0 string * Clang format fixes * fixing erroneous T0 and V0 changes * T0 and V0 namespace changes * clang-format fixes * T0 string changes * clang-format fixes * T0 function names, variables, file path * renaming files, directories, #includes, cmakes * more file renames, directory renames * V0 string changes * V0 comments, variables, and functions * updated V0 variable * more T0 strings, comments, and FITT0, FIT_T0 * more T0 strings, comments, and FITT0, FIT_T0 again * FIT V0 renames * lowercase t0 changes * V0 file and directory names, T0 string * Clang format fixes * fixing erroneous T0 and V0 changes * Clang format fixed * Revert "fixing erroneous T0 and V0 changes" This reverts commit 30ba3bd. * Revert "Clang format fixed" This reverts commit ebbebd7. * clang format fixes * fixing erroneous T0 and V0 changes * Simplify containers in FV0 from TVector3's to TPoint3D and TVector3D * merge conflict solved * clang format after merge * revert accidental changes * Update testDCAFitter.cxx
carlos-soncco
pushed a commit
to carlos-soncco/AliceO2
that referenced
this pull request
Oct 28, 2019
* T0 and V0 namespace changes * clang-format fixes * T0 string changes * clang-format fixes * T0 function names, variables, file path * renaming files, directories, #includes, cmakes * more file renames, directory renames * V0 string changes * V0 comments, variables, and functions * updated V0 variable * more T0 strings, comments, and FITT0, FIT_T0 * more T0 strings, comments, and FITT0, FIT_T0 again * FIT V0 renames * lowercase t0 changes * V0 file and directory names, T0 string * Clang format fixes * fixing erroneous T0 and V0 changes * T0 and V0 namespace changes * clang-format fixes * T0 string changes * clang-format fixes * T0 function names, variables, file path * renaming files, directories, #includes, cmakes * more file renames, directory renames * V0 string changes * V0 comments, variables, and functions * updated V0 variable * more T0 strings, comments, and FITT0, FIT_T0 * more T0 strings, comments, and FITT0, FIT_T0 again * FIT V0 renames * lowercase t0 changes * V0 file and directory names, T0 string * Clang format fixes * fixing erroneous T0 and V0 changes * Clang format fixed * Revert "fixing erroneous T0 and V0 changes" This reverts commit 30ba3bd. * Revert "Clang format fixed" This reverts commit ebbebd7. * clang format fixes * fixing erroneous T0 and V0 changes * Simplify containers in FV0 from TVector3's to TPoint3D and TVector3D * merge conflict solved * clang format after merge * revert accidental changes * Update testDCAFitter.cxx
EmilGorm
pushed a commit
to EmilGorm/AliceO2
that referenced
this pull request
Apr 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.