Renaming T0 and V0 to comply with convention#2255
Renaming T0 and V0 to comply with convention#2255rnevils wants to merge 16 commits intoAliceO2Group:devAliceO2Group/AliceO2:devfrom
Conversation
|
@AllaMaevskaya could you also have a look? |
shahor02
left a comment
There was a problem hiding this comment.
Hi @rnevils
Strictly speaking, the names should be no longer than 3 (+1 for termination) characters...
Anyway, this PR also touched a few files where V0 and T0 refer to secondary vertex or time0 of TPC, see below, these should be reverted.
Just for the record: this namespace change in PR will invalidate the large data sets I have announced a few days ago...
| float dst = TMath::Sqrt(dx * dx + dy * dy + dz * dz); | ||
|
|
||
| const auto &trc0 = fitter.getTrack0(ic), &trc1 = fitter.getTrack1(ic); // track parameters at V0 | ||
| const auto &trc0 = fitter.getTrack0(ic), &trc1 = fitter.getTrack1(ic); // track parameters at FV0 |
There was a problem hiding this comment.
The V0 here is for the secondary vertex, not the detector... Please undo the changes for this file.
| { | ||
| auto f = std::unique_ptr<TFile>(TFile::Open(filename.c_str(), "recreate")); | ||
| f->WriteObject(&mT0, "T0"); | ||
| f->WriteObject(&mT0, "FT0"); |
There was a problem hiding this comment.
Here also, T0 refers to time0 of the TPC trigger, not detector, please change back.
| V0NegativeDaughter, | ||
| V0PositiveDaughter, | ||
| V0Mother, | ||
| FV0NegativeDaughter, |
There was a problem hiding this comment.
Please revert this also, V0 here is for the secondary vertex.
All instances (variables, files, strings, etc) of "T0" and "V0" are to be changed to "FT0" and "FV0" for consistency, and to comply with the 3 letter naming convention of detectors.