fix(tiff): The "tiff:half" hint was only applying to first MIP level#5240
Merged
lgritz merged 1 commit intoJun 28, 2026
Merged
fix(tiff): The "tiff:half" hint was only applying to first MIP level#5240lgritz merged 1 commit into
lgritz merged 1 commit into
Conversation
IBA::make_texture() only passes the full metadata to the first level of a MIPmap, and that might include output behavior hints, too! Make this hint "sticky" in the TIFF writer, so if any subimage's first level's spec enables half output, all the MIP levels of that subimage will allow it. Signed-off-by: Larry Gritz <lg@larrygritz.com>
Collaborator
Author
|
Any opinions? |
Collaborator
Author
|
2 weeks, no objections -> merging |
lgritz
added a commit
that referenced
this pull request
Jul 1, 2026
…5240) IBA::make_texture() only passes the full metadata to the first level of a MIPmap, and that might include output behavior hints, too! Make this hint "sticky" in the TIFF writer, so if any subimage's first level's spec enables half output, all the MIP levels of that subimage will allow it. Fixes #5239 Signed-off-by: Larry Gritz <lg@larrygritz.com>
lgritz
added a commit
that referenced
this pull request
Jul 15, 2026
…5240) IBA::make_texture() only passes the full metadata to the first level of a MIPmap, and that might include output behavior hints, too! Make this hint "sticky" in the TIFF writer, so if any subimage's first level's spec enables half output, all the MIP levels of that subimage will allow it. Fixes #5239 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IBA::make_texture() only passes the full metadata to the first level of a MIPmap, and that might include output behavior hints, too! Make this hint "sticky" in the TIFF writer, so if any subimage's first level's spec enables half output, all the MIP levels of that subimage will allow it.
Fixes #5239