Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add abstract methods for SearchableAPIResource#873

Merged
yejia-stripe merged 1 commit into
masterstripe/stripe-python:masterfrom
yejia/search-api-resource-methodsstripe/stripe-python:yejia/search-api-resource-methodsCopy head branch name to clipboard
Sep 6, 2022
Merged

Add abstract methods for SearchableAPIResource#873
yejia-stripe merged 1 commit into
masterstripe/stripe-python:masterfrom
yejia/search-api-resource-methodsstripe/stripe-python:yejia/search-api-resource-methodsCopy head branch name to clipboard

Conversation

@yejia-stripe

@yejia-stripe yejia-stripe commented Sep 6, 2022

Copy link
Copy Markdown
Contributor

r? @anniel-stripe

Summary

Add search and search_auto_paging_iter "abstract methods" for SearchableAPIResource. This is functionally a no-op, but fixes the tests for the type annotation stubs here: https://github.com/python/typeshed/runs/8215124463

@anniel-stripe anniel-stripe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.