Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

test(touch): add coverage for -d option#925

Merged
nfischer merged 1 commit into
mastershelljs/shelljs:masterfrom
test-touch-dateshelljs/shelljs:test-touch-dateCopy head branch name to clipboard
Jan 4, 2019
Merged

test(touch): add coverage for -d option#925
nfischer merged 1 commit into
mastershelljs/shelljs:masterfrom
test-touch-dateshelljs/shelljs:test-touch-dateCopy head branch name to clipboard

Conversation

@nfischer

@nfischer nfischer commented Jan 4, 2019

Copy link
Copy Markdown
Member

No change to production logic.

We never had coverage for touch({'-d': ...}), so this adds test
coverage. This also updates documentation to clarify the parameter
should be an instance of the Date type.

Test: handles date argument case

No change to production logic.

We never had coverage for `touch({'-d': ...})`, so this adds test
coverage. This also updates documentation to clarify the parameter
should be an instance of the `Date` type.

Test: `handles date argument` case
@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #925 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #925   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files          34       34           
  Lines        1281     1281           
=======================================
  Hits         1246     1246           
  Misses         35       35
Impacted Files Coverage Δ
src/touch.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 355287e...e1fb25a. Read the comment docs.

@nfischer

nfischer commented Jan 4, 2019

Copy link
Copy Markdown
Member Author

This was covered by some cp.js tests, but it's probably clearer to put a test in touch.js anyway.

@nfischer
nfischer merged commit 5371e16 into master Jan 4, 2019
@nfischer
nfischer deleted the test-touch-date branch January 4, 2019 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.