Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[ANR] Reduced AndroidTransactionProfiler lock - #4817

#4817
Merged
stefanosiano merged 8 commits into
maingetsentry/sentry-java:mainfrom
stefanosiano/enh/remove-profiling-lockgetsentry/sentry-java:stefanosiano/enh/remove-profiling-lockCopy head branch name to clipboard
Oct 28, 2025
Merged

[ANR] Reduced AndroidTransactionProfiler lock#4817
stefanosiano merged 8 commits into
maingetsentry/sentry-java:mainfrom
stefanosiano/enh/remove-profiling-lockgetsentry/sentry-java:stefanosiano/enh/remove-profiling-lockCopy head branch name to clipboard

Conversation

@stefanosiano

@stefanosiano stefanosiano commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

📜 Description

Removed lock from AndroidTransactionProfiler

💡 Motivation and Context

Trying to reduce ANRs. There are reports of ANRs happening when getting the lock on transaction start/end

resolves #4792

💚 How did you test it?

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@stefanosiano
stefanosiano marked this pull request as ready for review October 20, 2025 11:32
cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Oct 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 296.36 ms 354.42 ms 58.06 ms
Size 1.58 MiB 2.12 MiB 551.16 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d217708 375.27 ms 415.68 ms 40.41 ms
ee747ae 405.43 ms 485.70 ms 80.28 ms
3d205d0 352.15 ms 432.53 ms 80.38 ms
b3d8889 371.33 ms 426.24 ms 54.92 ms
27d7cf8 309.43 ms 364.27 ms 54.85 ms
17a0955 372.53 ms 446.70 ms 74.17 ms
c8125f3 383.82 ms 441.66 ms 57.84 ms
bdbe1f4 380.66 ms 464.44 ms 83.78 ms
f634d01 375.06 ms 420.04 ms 44.98 ms
ee747ae 415.92 ms 470.15 ms 54.23 ms

App size

Revision Plain With Sentry Diff
d217708 1.58 MiB 2.10 MiB 532.97 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
3d205d0 1.58 MiB 2.10 MiB 532.97 KiB
b3d8889 1.58 MiB 2.10 MiB 535.07 KiB
27d7cf8 1.58 MiB 2.12 MiB 549.42 KiB
17a0955 1.58 MiB 2.10 MiB 533.20 KiB
c8125f3 1.58 MiB 2.10 MiB 532.32 KiB
bdbe1f4 1.58 MiB 2.11 MiB 538.88 KiB
f634d01 1.58 MiB 2.10 MiB 533.40 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: stefanosiano/enh/remove-profiling-lock

Startup times

Revision Plain With Sentry Diff
9d937d0 351.00 ms 486.74 ms 135.74 ms
7bf9f04 329.80 ms 401.20 ms 71.41 ms
54a0e3d 313.70 ms 369.06 ms 55.36 ms
6329f7d 302.88 ms 357.80 ms 54.92 ms

App size

Revision Plain With Sentry Diff
9d937d0 1.58 MiB 2.12 MiB 549.09 KiB
7bf9f04 1.58 MiB 2.12 MiB 548.08 KiB
54a0e3d 1.58 MiB 2.12 MiB 549.09 KiB
6329f7d 1.58 MiB 2.11 MiB 539.66 KiB

romtsn
romtsn reviewed Oct 20, 2025
View reviewed changes
Comment thread sentry-android-core/src/main/java/io/sentry/android/core/AndroidProfiler.java
@stefanosiano stefanosiano changed the title [ANR] Removed AndroidTransactionProfiler lock [ANR] Reduced AndroidTransactionProfiler lock Oct 21, 2025
romtsn
romtsn reviewed Oct 24, 2025
View reviewed changes
Comment thread sentry-android-core/src/main/java/io/sentry/android/core/AndroidTransactionProfiler.java Outdated
romtsn
romtsn reviewed Oct 24, 2025
View reviewed changes
Comment thread sentry-android-core/src/main/java/io/sentry/android/core/AndroidTransactionProfiler.java Outdated
cursor[bot]

This comment was marked as outdated.

Sign in to view

cursor[bot]

This comment was marked as outdated.

Sign in to view

@stefanosiano
stefanosiano merged commit 725987d into main Oct 28, 2025
58 of 61 checks passed
@stefanosiano
stefanosiano deleted the stefanosiano/enh/remove-profiling-lock branch October 28, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romtsn romtsn romtsn approved these changes
@cursor cursor[bot] cursor[bot] left review comments
@adinauer adinauer Awaiting requested review from adinauer adinauer is a code owner
@markushi markushi Awaiting requested review from markushi markushi is a code owner
@lcian lcian Awaiting requested review from lcian

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

io.sentry.android.core.ApplicationNotResponding: Background ANR

2 participants

@stefanosiano @romtsn
Morty Proxy This is a proxified and sanitized view of the page, visit original site.