test(sourcemaps): Assert injection outputs - #2483
#2483Merged
szokeasaurusrex merged 1 commit intoApr 30, 2025
mastergetsentry/sentry-cli:masterfrom
szokeasaurusrex/assert-inject-contentsgetsentry/sentry-cli:szokeasaurusrex/assert-inject-contentsCopy head branch name to clipboard
Merged
test(sourcemaps): Assert injection outputs#2483szokeasaurusrex merged 1 commit intomastergetsentry/sentry-cli:masterfrom szokeasaurusrex/assert-inject-contentsgetsentry/sentry-cli:szokeasaurusrex/assert-inject-contentsCopy head branch name to clipboard
szokeasaurusrex merged 1 commit into
mastergetsentry/sentry-cli:masterfrom
szokeasaurusrex/assert-inject-contentsgetsentry/sentry-cli:szokeasaurusrex/assert-inject-contentsCopy head branch name to clipboard
Conversation
szokeasaurusrex
force-pushed
the
szokeasaurusrex/assert-inject-contents
branch
from
April 30, 2025 12:33
b3f2396 to
102820b
Compare
szokeasaurusrex
marked this pull request as ready for review
April 30, 2025 12:57
loewenheim
approved these changes
Apr 30, 2025
loewenheim
left a comment
Contributor
There was a problem hiding this comment.
Nice, that's much cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of our tests for
sourcemaps injectonly assert the stdout of the command and its exit status, but do not verify that the injected files match our expectation.This test introduces a generalized method to verify the outputs of the commands. The expected outputs have been copied from the actual outputs of the tests at the time of authoring this commit; I assume that the current behavior is the correct behavior.
Closes #2482