Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove trailing comma #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove trailing comma #101

wants to merge 1 commit into from

Conversation

Kazade
Copy link

@Kazade Kazade commented Oct 7, 2020

Fixes #100

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #100 🦕

@google-cla
Copy link

google-cla bot commented Oct 7, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 7, 2020
@Kazade
Copy link
Author

Kazade commented Oct 7, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 7, 2020
tseaver added a commit that referenced this pull request Oct 7, 2020
@tseaver
Copy link
Contributor

tseaver commented Oct 7, 2020

@Kazade Thanks for the patch! I think we need to do actual tests that the deprecation message is a string, rather than a tuple, so I've pushed PR #103, which supersedes this PR.

@tseaver tseaver closed this Oct 7, 2020
tseaver added a commit that referenced this pull request Nov 11, 2020
Closes #101
Closes #100

Co-authored-by: Christopher Wilcox <crwilcox@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Excess comma in reserve_ids breaks the function
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.