The Wayback Machine - https://web.archive.org/web/20241219052944/https://github.com/symfony/symfony/pull/58705
Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serializer] Revert Default groups #58705

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Oct 29, 2024

Q A
Branch? 7.1
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58576, Fix #57350
License MIT

When introduced in #51514, the behavior of group selection was wrong and introduced BC breaks (see the two related issues).

This PR reverts this introduction so that they can be added properly in 7.3 (see #58656).

@fabpot
Copy link
Member

fabpot commented Nov 9, 2024

Thank you @mtarld.

@fabpot fabpot merged commit e713ac2 into symfony:7.1 Nov 9, 2024
9 of 10 checks passed
@mtarld mtarld deleted the fix/revert-default-groups branch November 9, 2024 07:07
This was referenced Nov 13, 2024
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Nov 13, 2024
…p change (xabbuh)

This PR was merged into the 7.1 branch.

Discussion
----------

[Serializer] remove note about the reverted Default group change

revert #19526 as symfony/symfony#51514 was reverted in symfony/symfony#58705

Commits
-------

626d56e remove note about the reverted Default group change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.