node-api: generalize finalizer second pass callback

Generalize the finalizer's second pass callback to make it cancellable and simplify the code around the second pass callback. With this change, it is determined that Reference::Finalize or RefBase::Finalize are called once, either from the env's shutdown, or from the env's second pass callback. All existing node-api js tests should pass without a touch. The js_native_api cctest is no longer applicable with this change, just removing it. PR-URL: #44141 Refs: #44071 Reviewed-By: Michael Dawson <midawson@redhat.com>
nodejs · Jan 24, 2023 · 6e9676e · 6e9676e
1 parent 14c95ec
commit 6e9676e
Show file tree

Hide file tree

Showing 8 changed files with 317 additions and 413 deletions.
diff --git a/node.gyp b/node.gyp
@@ -1241,7 +1241,6 @@
        'test/cctest/test_base_object_ptr.cc',
        'test/cctest/test_node_postmortem_metadata.cc',
        'test/cctest/test_environment.cc',
-        'test/cctest/test_js_native_api_v8.cc',
        'test/cctest/test_linked_binding.cc',
        'test/cctest/test_node_api.cc',
        'test/cctest/test_per_process.cc',