The Wayback Machine - https://web.archive.org/web/20230131200320/https://github.com/nodejs/node/pull/46315
Skip to content
Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: remove brandchecks from stream duplexify #46315

Merged
merged 1 commit into from Jan 25, 2023
Merged

stream: remove brandchecks from stream duplexify #46315

merged 1 commit into from Jan 25, 2023

Conversation

debadree25
Copy link
Contributor

Using imports from webstreams could cause dependency issues in readable-stream as referenced in the discussion, hence removing brandchecks and replacing with utils in streams

Refs: #46190
Refs: #46205 (comment)

@nodejs-github-bot
Copy link
Contributor

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 23, 2023
@debadree25
Copy link
Contributor Author

cc @ronag

ronag
ronag approved these changes Jan 23, 2023
View changes
@ronag
Copy link
Member

ronag commented Jan 23, 2023

Thanks!

@debadree25
Copy link
Contributor Author

I think for backporting #46190 we could do it after this one lands? cc @aduh95

@debadree25 debadree25 mentioned this pull request Jan 23, 2023
Draft
mcollina
mcollina approved these changes Jan 23, 2023
View changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2023
ronag
ronag approved these changes Jan 23, 2023
View changes
@nodejs-github-bot
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/49139/

lpinca
lpinca approved these changes Jan 23, 2023
View changes
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2023
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit ea5a123 into nodejs:main Jan 25, 2023
56 checks passed
@nodejs-github-bot
Copy link
Contributor

Landed in ea5a123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina

@addaleax addaleax

@benjamingr benjamingr

@lpinca lpinca

@ronag ronag

@RaisinTen RaisinTen

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@debadree25 @nodejs-github-bot @ronag @mcollina @addaleax @benjamingr @lpinca @RaisinTen
Morty Proxy This is a proxified and sanitized view of the page, visit original site.