The Wayback Machine - https://web.archive.org/web/20250407173040/https://github.com/nodejs/node/commit/3919edb47e
Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Commit 3919edb

Browse filesBrowse files
bnoordhuisMyles Borins
bnoordhuis
authored and
Myles Borins
committed
build: don't build icu with -fno-rtti
ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867 PR-URL: #8886 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
1 parent a3a184d commit 3919edb
Copy full SHA for 3919edb

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

‎tools/icu/icu-generic.gyp

Copy file name to clipboardexpand all lines: tools/icu/icu-generic.gyp
+1
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
[ 'os_posix == 1 and OS != "mac" and OS != "ios"', {
7070
'cflags': [ '-Wno-deprecated-declarations' ],
7171
'cflags_cc': [ '-frtti' ],
72+
'cflags_cc!': [ '-fno-rtti' ],
7273
}],
7374
[ 'OS == "mac" or OS == "ios"', {
7475
'xcode_settings': {'GCC_ENABLE_CPP_RTTI': 'YES' },

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.