New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect cast in StrictOptimizedMapOps.+ #10239
Conversation
|
/rebuild |
|
Oh, not spurious. I couldn't see the cause but travis shows Ha, ha. Fixable by adding Could also remove extra space |
|
Travis also reports |
|
Edit: I tried deprecating the test method and it still errors out locally. At least TIL Oh I didn't read the message carefully: This was a pre-deprecation warning. I'll try Also this makes my blood boil every time: Of course it's also necessary to suppress the deprecation of the method. |
| @@ -141,4 +141,11 @@ class MapTest { | ||
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @deprecated("tests deprecated API", "") | |
| @nowarn("cat=lint-multiarg-infix") |
|
Probably lrytz didn't notice that I added a commit... I assumed he was asleep, I didn't check the time zones. I must have done it wrong: https://scala-ci.typesafe.com/job/scala-2.13.x-validate-main/16757/ |
|
I'm sorry :-/ I saw the fatal warning three hours ago and now just came back to fix it without paying attention. Feel free to push -f e876cb7 again! |
|
I don't understand how it passes with your nowarn, so I won't attempt it again. Later, I'll try to figure it out, maybe after I do some advent of code. |
|
I'm using |
|
Thanks, my eyes were too bleary to see it. |


Fixes scala/bug#12699