test: clean up test-buffer-badhex

This test was recently (at the time of writing) introduced in 151d316 and could be cleaned up a bit. Refs: #7602 PR-URL: #7773 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Oct 26, 2016 · 741373cb49f855c4fb1ad06ad5cdf61caa338114 · 741373c
1 parent 17c4187
commit 741373cb49f855c4fb1ad06ad5cdf61caa338114
Showing with 33 additions and 27 deletions.

+33 −27 test/parallel/test-buffer-badhex.js
diff --git a/test/parallel/test-buffer-badhex.js b/test/parallel/test-buffer-badhex.js
@@ -5,39 +5,45 @@ const Buffer = require('buffer').Buffer;

 // Test hex strings and bad hex strings
 {
-  const buf1 = Buffer.alloc(4);
-  assert.strictEqual(buf1.length, 4);
-  assert.deepStrictEqual(buf1, new Buffer([0, 0, 0, 0]));
-  assert.strictEqual(buf1.write('abcdxx', 0, 'hex'), 2);
-  assert.deepStrictEqual(buf1, new Buffer([0xab, 0xcd, 0x00, 0x00]));
-  assert.strictEqual(buf1.toString('hex'), 'abcd0000');
-  assert.strictEqual(buf1.write('abcdef01', 0, 'hex'), 4);
-  assert.deepStrictEqual(buf1, new Buffer([0xab, 0xcd, 0xef, 0x01]));
-  assert.strictEqual(buf1.toString('hex'), 'abcdef01');
+  const buf = Buffer.alloc(4);
+  assert.strictEqual(buf.length, 4);
+  assert.deepStrictEqual(buf, new Buffer([0, 0, 0, 0]));
+  assert.strictEqual(buf.write('abcdxx', 0, 'hex'), 2);
+  assert.deepStrictEqual(buf, new Buffer([0xab, 0xcd, 0x00, 0x00]));
+  assert.strictEqual(buf.toString('hex'), 'abcd0000');
+  assert.strictEqual(buf.write('abcdef01', 0, 'hex'), 4);
+  assert.deepStrictEqual(buf, new Buffer([0xab, 0xcd, 0xef, 0x01]));
+  assert.strictEqual(buf.toString('hex'), 'abcdef01');

-  const buf2 = Buffer.from(buf1.toString('hex'), 'hex');
-  assert.strictEqual(buf1.toString('hex'), buf2.toString('hex'));
+  const copy = Buffer.from(buf.toString('hex'), 'hex');
+  assert.strictEqual(buf.toString('hex'), copy.toString('hex'));
+}

-  const buf3 = Buffer.alloc(5);
-  assert.strictEqual(buf3.write('abcdxx', 1, 'hex'), 2);
-  assert.strictEqual(buf3.toString('hex'), '00abcd0000');
+{
+  const buf = Buffer.alloc(5);
+  assert.strictEqual(buf.write('abcdxx', 1, 'hex'), 2);
+  assert.strictEqual(buf.toString('hex'), '00abcd0000');
+}

-  const buf4 = Buffer.alloc(4);
-  assert.deepStrictEqual(buf4, new Buffer([0, 0, 0, 0]));
-  assert.strictEqual(buf4.write('xxabcd', 0, 'hex'), 0);
-  assert.deepStrictEqual(buf4, new Buffer([0, 0, 0, 0]));
-  assert.strictEqual(buf4.write('xxab', 1, 'hex'), 0);
-  assert.deepStrictEqual(buf4, new Buffer([0, 0, 0, 0]));
-  assert.strictEqual(buf4.write('cdxxab', 0, 'hex'), 1);
-  assert.deepStrictEqual(buf4, new Buffer([0xcd, 0, 0, 0]));
+{
+  const buf = Buffer.alloc(4);
+  assert.deepStrictEqual(buf, new Buffer([0, 0, 0, 0]));
+  assert.strictEqual(buf.write('xxabcd', 0, 'hex'), 0);
+  assert.deepStrictEqual(buf, new Buffer([0, 0, 0, 0]));
+  assert.strictEqual(buf.write('xxab', 1, 'hex'), 0);
+  assert.deepStrictEqual(buf, new Buffer([0, 0, 0, 0]));
+  assert.strictEqual(buf.write('cdxxab', 0, 'hex'), 1);
+  assert.deepStrictEqual(buf, new Buffer([0xcd, 0, 0, 0]));
+}

-  const buf5 = Buffer.alloc(256);
+{
+  const buf = Buffer.alloc(256);
  for (let i = 0; i < 256; i++)
-    buf5[i] = i;
+    buf[i] = i;

-  const hex = buf5.toString('hex');
-  assert.deepStrictEqual(Buffer.from(hex, 'hex'), buf5);
+  const hex = buf.toString('hex');
+  assert.deepStrictEqual(Buffer.from(hex, 'hex'), buf);

  const badHex = hex.slice(0, 256) + 'xx' + hex.slice(256, 510);
-  assert.deepStrictEqual(Buffer.from(badHex, 'hex'), buf5.slice(0, 128));
+  assert.deepStrictEqual(Buffer.from(badHex, 'hex'), buf.slice(0, 128));
 }