[FrameworkBundle] Split loggers debug compiler pass #48041
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d93eb06 to
3f17d62
Compare
|
This would be a BC break or am I wrong? |
|
@maxbeckers how? Are compiler passes configurators part of Symfony’s public API? |
|
My two thoughts were renaming the class and changing the priorities. It's only debug compiler passes, but wanted to at least note it. That's why I'm not sure if it's a BC break or not. |
3f17d62 to
7a3bbd1
Compare
|
@fabpot I see you changed the milestone to 6.3 but this PR is supposed to be a fix for a feature introduced in 6.2. Is that alright? |
|
In that case, 6.2 is indeed the right target. |
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/EnableLoggerDebugModePass.php
Outdated
Show resolved
Hide resolved
7a3bbd1 to
980df7a
Compare
stof
approved these changes
Nov 10, 2022
980df7a to
926f3de
Compare
|
Thank you @MatTheCat. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Monolog and HttpKernel’s loggers have nothing to do with each other I feel like giving each one its own compiler pass is best.