Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upworkaround the case of a non-public email #78
Conversation
joschi
commented
Dec 14, 2014
|
|
Uncomment when github/maven-plugins#78 has been merged.
Uncomment when github/maven-plugins#78 has been merged.
Uncomment when github/maven-plugins#78 has been merged.
Uncomment when github/maven-plugins#78 has been merged.
Uncomment when github/maven-plugins#78 has been merged.
| @@ -433,7 +433,7 @@ public void execute() throws MojoExecutionException { | ||
|
|
||
| CommitUser author = new CommitUser(); | ||
| author.setName(user.getName()); | ||
| author.setEmail(user.getEmail()); | ||
| author.setEmail(userService.getEmails().get(0)); |
This comment has been minimized.
This comment has been minimized.
kevinsawicki
Jan 16, 2015
Member
Should this use user.getEmail() when available and only fall back to userService.getEmails().get(0) when the first is null/empty?
This comment has been minimized.
This comment has been minimized.
mprins
Jan 17, 2015
Author
Contributor
that might work as well; you'd have to give it a try.
I don't know the specifics of of the egit api anymore and don't have time atm.
workaround the case of a non-public email
|
Thanks for this, apologies for the delay |
|
Released 0.11 to Maven Central just now, thanks again. |
farolfo
commented
Jan 21, 2015
|
Thanks for this !! |
Yeah, I think it still takes hours to sync to maven central. You can use https://oss.sonatype.org/#nexus-search;quick~github-maven-plugins in the interim if you need. |
Uncomment when github/maven-plugins#78 has been merged.
Uncomment when github/maven-plugins#78 has been merged.
This comment has been minimized.
This comment has been minimized.
juanplopes
commented on github-site-plugin/src/main/java/com/github/maven/plugins/site/SiteMojo.java in 66b1470
May 19, 2015
|
This change breaks the plugin to me. I had to revert this change in order to make it work. |
mprins commentedOct 31, 2014
As proposed by some others, this works around the issue of not having a public email address on your github profile.
close #69
close #70
close #71
close #73
close #77