The Wayback Machine - https://web.archive.org/web/20220524054353/https://github.com/vuejs/vuepress/pull/2162
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): add dependabot configuration #2162

Merged

Conversation

vinayakkulkarni
Copy link
Contributor

@vinayakkulkarni vinayakkulkarni commented Feb 1, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

  • Enables dependabot to ensure all dependencies are always up to date!

PS. I've set the default reviewer to me, but it can be anyone from the core team.
// cc @bencodezen, @ulivz

@meteorlxy
Copy link
Member

@meteorlxy meteorlxy commented Feb 1, 2020

I think this should be categorized as "build-related changes" rather than a feature

@vinayakkulkarni vinayakkulkarni changed the title feat(deps): add dependabot configuration build(deps): add dependabot configuration Feb 1, 2020
@bencodezen
Copy link
Member

@bencodezen bencodezen commented Feb 2, 2020

@vinayakkulkarni My apologies if this sounds like a stupid question. So does this PR help to enforce package.json / lock files in people's PRs going forward? I'm not familiar with the changes your submitting, so appreciate any guidance you can provide!

@vinayakkulkarni
Copy link
Contributor Author

@vinayakkulkarni vinayakkulkarni commented Feb 4, 2020

Sorry about the late response,

The config does not enforce anything in peoples' PRs, it basically removes user intervention in bumping the package dependencies version.

Basically, automates #2157 via dependabot Bot so that the package dependencies are automatically up-to-date.

@billyyyyy3320
Copy link
Collaborator

@billyyyyy3320 billyyyyy3320 commented May 2, 2020

Agree that we need a bot to keep updating dependencies. However, I don't have many experience in it. What the pros and cons between Renovate and Dependabot?

@vinayakkulkarni
Copy link
Contributor Author

@vinayakkulkarni vinayakkulkarni commented May 4, 2020

Agree that we need a bot to keep updating dependencies. However, I don't have many experience in it. What the pros and cons between Renovate and Dependabot?

I've been using dependabot for a long time now and now since it's owned by GitHub, it's even more awesomer!

Last time I tried using renovate, i had some billing related issue.. will have to explore Renovate pricing & plans though.

@vinayakkulkarni vinayakkulkarni force-pushed the feat/add-dependabot-configuration branch from 8169aff to 1ea4f68 Compare Jun 1, 2020
.dependabot/config.yml Outdated Show resolved Hide resolved
@bencodezen bencodezen merged commit 8f42f56 into vuejs:master Jul 21, 2020
2 of 6 checks passed
@bencodezen
Copy link
Member

@bencodezen bencodezen commented Jul 21, 2020

Thanks for working on this @vinayakkulkarni!

@vinayakkulkarni
Copy link
Contributor Author

@vinayakkulkarni vinayakkulkarni commented Jul 21, 2020

Thanks for working on this @vinayakkulkarni!

<3

btw, dependabot was acquired by GitHub, I'll create a new PR to support v2 of dependabot

@vinayakkulkarni vinayakkulkarni deleted the feat/add-dependabot-configuration branch Jul 21, 2020
larionov pushed a commit to larionov/vuepress that referenced this issue Aug 19, 2020
* feat: add dependabot configuration

* config: update .dependabot/config.yml

Co-authored-by: Ben Hong <ben@bencodezen.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.