The Wayback Machine - https://web.archive.org/web/20220516043114/https://github.com/TheAlgorithms/JavaScript/pull/1005
Skip to content
Sign up
Sign in
Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved the complexity of dequeue O(n) to O(1) #1005

Merged
merged 46 commits into from May 6, 2022
Merged

Improved the complexity of dequeue O(n) to O(1) #1005

merged 46 commits into from May 6, 2022

Conversation

fahimfaisaal
Copy link
Contributor

@fahimfaisaal fahimfaisaal commented May 6, 2022

Open in Gitpod know more

Describe your change:

  • Removed the view method & added the peekLast and toArray method
  • Upgraded some documentation
  • Added some more test cases
  • Resolved - #942

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

fahimfaisaal and others added 30 commits Mar 2, 2022
@fahimfaisaal
feat: improved memoize function
72def41 
used Map instead of object & used the JSON.stringfy method for generate a valid string as a key
@fahimfaisaal
docs: modified documentation
8548ef1
@fahimfaisaal
style: format with standard
ce9d3b9
@fahimfaisaal
docs: modified stringify doc
1e2fb53
@fahimfaisaal
refactor: remove two repetition implementation
2a5c28b
@fahimfaisaal
feat: added validation, test codes
c582f58
@fahimfaisaal
chore: remove useless words
cdff0e3
@fahimfaisaal
feat: added types for jest
5727b64
@fahimfaisaal
Merge branch 'upgrade-abs' of https://github.com/fahimfaisaal/Javascript
025a8b8 
 into upgrade-abs
@fahimfaisaal
chore: added link box
9efda24
@fahimfaisaal
feat: added new validation test casses & methods
98ffd1d
@fahimfaisaal
style: formated with standard
b8d6e68
@fahimfaisaal
feat: added parse method & test cases
b7c961c
@fahimfaisaal
docs: added js docs
6b7b715
@fahimfaisaal
chore: added default import export
269a3f4
@fahimfaisaal
feat: imporved algorithm via replace method
5cedaa9
@fahimfaisaal
test: added two test cases
d00a7bf
@fahimfaisaal
feat: added jest type for suggestions
bbcce39
@fahimfaisaal
feat: added reduceRight & trim method
9be30a8
@fahimfaisaal
chore: added helper variable
489544d
@fahimfaisaal
feat: added new rotation option
68cb5ad
@fahimfaisaal
Revert "chore: added helper variable"
addf721 
This reverts commit 489544d.
@fahimfaisaal
Merge branch 'TheAlgorithms:master' into master
07a2b17
@fahimfaisaal
Merge branch 'upgrade-CaesarsCipher'
8c297ae
@fahimfaisaal
Merge branch 'upgrade-reverseWord'
605cfb7
@fahimfaisaal
Merge branch 'upgrade-packageJson'
6636af2
@fahimfaisaal
Merge branch 'upgrade-LRU'
3905c5d
@fahimfaisaal
Merge branch 'upgrade-ciphers'
42b13b8
@fahimfaisaal
Merge branch 'upgrade-memoize'
64981b7
@fahimfaisaal
Merge branch 'upgrade-abs'
e1c6666
appgurueu
appgurueu requested changes May 6, 2022
View changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Please address the issues and remove all capacity-related code. Otherwise LGTM.

Data-Structures/Queue/Queue.js Show resolved Hide resolved
Data-Structures/Queue/Queue.js Outdated Show resolved Hide resolved
Data-Structures/Queue/Queue.js Show resolved Hide resolved
Data-Structures/Queue/Queue.js Outdated Show resolved Hide resolved
Data-Structures/Queue/Queue.js Show resolved Hide resolved
Data-Structures/Queue/test/Queue.test.js Outdated Show resolved Hide resolved
appgurueu
appgurueu previously approved these changes May 6, 2022
View changes
@appgurueu appgurueu added code quality performance labels May 6, 2022
@raklaptudirm raklaptudirm added the algorithm label May 6, 2022
@raklaptudirm raklaptudirm merged commit e05b443 into TheAlgorithms:master May 6, 2022
3 checks passed
@raklaptudirm raklaptudirm mentioned this pull request May 6, 2022
Closed
@fahimfaisaal fahimfaisaal deleted the upgrade-queue branch May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu

@raklaptudirm raklaptudirm

Assignees
No one assigned
Labels
algorithm code quality performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fahimfaisaal @appgurueu @raklaptudirm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.