Upgraded Algorithm of alpha numeric palindrome #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used Map instead of object & used the JSON.stringfy method for generate a valid string as a key
This reverts commit 489544d.
|
@appgurueu Its node version should be updated cause |
|
@fahimfaisaal The tests are still failing. |
|
@raklaptudirm MDN said that after node v16.6.0 this method should work perfectly. and It's working perfectly on my machine when I'm using v16.15.0 via nvm. |
|
The runner is using that version: |
|
@fahimfaisaal try updating the dependencies in |
…ericPalindrome' of github.com:fahimfaisaal/Javascript into upgrade-alphaNumericPalindrome
|
@raklaptudirm Done |
appgurueu
reviewed
May 7, 2022
appgurueu
reviewed
May 7, 2022
appgurueu
reviewed
May 7, 2022
appgurueu
reviewed
May 7, 2022
appgurueu
previously approved these changes
May 7, 2022
appgurueu
approved these changes
May 7, 2022
raklaptudirm
approved these changes
May 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.